Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Add APM traces index names to Fleet enroll role #85802

Merged
merged 4 commits into from
Dec 15, 2020
Merged

[Fleet] Add APM traces index names to Fleet enroll role #85802

merged 4 commits into from
Dec 15, 2020

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Dec 14, 2020

This PR adds the additional APM data stream and template names to the permissions for the fleet_enroll role.

fixes #85761

How to test this

  1. Start up Kibana
  2. Enroll an Elastic Agent and add the APM integration
  3. Ingest some data, e.g. by sending example events via curl (curl -i -k -H "Content-type: application/x-ndjson" --data-binary @testdata.ndjson http://localhost:8200/intake/v2/events)

cc @ruflin

@simitt simitt added the v7.11.0 label Dec 14, 2020
@simitt simitt requested review from neptunian and a team December 14, 2020 16:25
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@simitt simitt mentioned this pull request Dec 14, 2020
Closed
@simitt simitt added the release_note:skip Skip the PR/issue when compiling release notes label Dec 14, 2020
nchaulet
nchaulet approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a test to update here x-pack/test/fleet_api_integration/apis/agent_setup.ts but otherwise LGTM 🚀

@simitt
Copy link
Contributor Author

simitt commented Dec 14, 2020

Also removed the events part as discussed async, as they are not needed anymore.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ruflin
ruflin approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-buttner @kevinlog This removes the permissions for the events-* indices. I'm pretty sure it is not used anymore and only a left over.

@simitt simitt merged commit 98308f8 into elastic:master Dec 15, 2020
@simitt simitt mentioned this pull request Dec 15, 2020
Merged
simitt added a commit to simitt/kibana that referenced this pull request Dec 15, 2020
@simitt
[Fleet] Change permissions for Fleet enroll role (elastic#85802)
91a5c56 
* Add APM traces index names to Fleet enroll role

* Removes fleet permissions for `events-*` as they became obsolete

fixes elastic#85761
simitt added a commit that referenced this pull request Dec 15, 2020
@simitt
[Fleet] Change permissions for Fleet enroll role (#85802) (#85916)
d0c88d5 
* Add APM traces index names to Fleet enroll role

* Removes fleet permissions for `events-*` as they became obsolete

fixes #85761
gmmorris added a commit to ymao1/kibana that referenced this pull request Dec 15, 2020
@gmmorris
Merge branch 'master' into pr/85462
fa70d31 
* master: (66 commits)
  [Alerting] fixes broken Alerting Example plugin (elastic#85774)
  [APM] Service overview instances table (elastic#85770)
  [Security Solution] Unskip timeline creation Cypress test (elastic#85871)
  properly recognize enterprise licenses (elastic#85849)
  [SecuritySolution][Detections] Adds SavedObject persistence to Signals Migrations (elastic#85690)
  [TSVB] Fix functional tests flakiness and unskip them (elastic#85388)
  [Fleet] Change permissions for Fleet enroll role (elastic#85802)
  Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 (elastic#84768)
  [Security Solution][Detections] Add alert source to detection rule action context (elastic#85488)
  [Discover] Don't display hide/show button for histogram when there's no time filter (elastic#85424)
  skip flaky suite (elastic#78553)
  License checks for alerts plugin (elastic#85649)
  skip flaky suite (elastic#84992)
  skip 'query return results valid for scripted field' elastic#78553
  Allow action types to perform their own mustache variable escaping in parameter templates (elastic#83919)
  [ML] More machine learning links in doc_links_service.ts (elastic#85365)
  Removed Alerting & Event Log deprecated fields that should not be using (elastic#85652)
  Closes elastic#79995 by adding new tab in transaction details to show related trace logs. (elastic#85859)
  Fix outdated jest snapshot
  [Maps] Surface on prem EMS (elastic#85729)
  ...
@jonathan-buttner
Copy link
Contributor

LGTM

@jonathan-buttner @kevinlog This removes the permissions for the events-* indices. I'm pretty sure it is not used anymore and only a left over.

Thanks for the heads up. Yeah we don't use events-* anymore 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

@nchaulet nchaulet nchaulet approved these changes

@neptunian neptunian Awaiting requested review from neptunian

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet][APM] APM Server via Elastic Agent Fleet is missing permissions to create data stream
6 participants
@simitt @elasticmachine @kibanamachine @jonathan-buttner @ruflin @nchaulet