Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require gold license for ECS audit logging #85537

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Require gold license for ECS audit logging #85537

merged 3 commits into from
Dec 10, 2020

Conversation

thomheymann
Copy link
Contributor

@thomheymann thomheymann commented Dec 10, 2020 •
edited
Loading

Summary

This PR changes the license for new ECS audit logger to >=Gold.

This is in order to align with Elasticsearch.

The legacy audit logger will remain available at >=Standard.

Checklist

Delete any items that are not applicable to this PR.

@thomheymann thomheymann requested a review from a team as a code owner December 10, 2020 11:18
@thomheymann thomheymann added Feature:Security/Audit Platform Security - Audit Logging feature release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Dec 10, 2020
legrego
legrego approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI! Thanks for taking care of this ❤️

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47010 47770 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
security 164.6KB 164.7KB +106.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomheymann thomheymann merged commit 051bbf0 into master Dec 10, 2020
@thomheymann thomheymann deleted the audit/changelicense branch December 10, 2020 16:34
@thomheymann thomheymann mentioned this pull request Dec 10, 2020
Merged
@thomheymann thomheymann restored the audit/changelicense branch December 10, 2020 17:02
@thomheymann thomheymann deleted the audit/changelicense branch December 10, 2020 17:41
thomheymann added a commit that referenced this pull request Dec 14, 2020
@thomheymann
Require gold license for ECS audit logging (#85537) (#85596)
52f8c27 
* Require gold license for ECS audit logging

* Fix unit test

* Add suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legrego legrego legrego approved these changes

Assignees
No one assigned
Labels
Feature:Security/Audit Platform Security - Audit Logging feature release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomheymann @kibanamachine @legrego