Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Switch InstallationStatus enum to approach from #82188 #82499

Merged
merged 2 commits into from
Nov 3, 2020
Merged

[Ingest Manager] Switch InstallationStatus enum to approach from #82188 #82499

merged 2 commits into from
Nov 3, 2020

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented Nov 3, 2020

Summary

Follow pattern from #82188. Same behavior as now. Stronger type safety.

  • installationSources is runtime value (JS object)
  • InstallationSource is TS type (typeof installationSources)
  • ValueOf<InstallationSource> is TS union type 'installed' | 'not_installed'
  • Can access values directly as installationSources.Installed (JS) or InstallationSource['Installed'] (TS)

@jfsiii jfsiii requested a review from a team as a code owner November 3, 2020 20:12
@jfsiii jfsiii requested a review from a team November 3, 2020 20:12
@jfsiii jfsiii requested a review from a team as a code owner November 3, 2020 20:12
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jfsiii
Copy link
Contributor Author

jfsiii commented Nov 3, 2020

@elasticmachine merge upstream

@jfsiii jfsiii added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Nov 3, 2020
@jfsiii jfsiii self-assigned this Nov 3, 2020
kevinlog
kevinlog approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@kevinlog kevinlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Endpoint changes LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
ingestManager 1.2MB 1.2MB -86.0B

page load bundle size

id before after diff
ingestManager 386.1KB 385.9KB -122.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii merged commit 13dae5e into elastic:master Nov 3, 2020
@jfsiii jfsiii mentioned this pull request Nov 5, 2020
Merged
jfsiii pushed a commit that referenced this pull request Nov 5, 2020
Switch to new 'as const' + typeof + ValueOf approach (#82499) (#82681)
778d662 
## Summary

Follow pattern from #82188. Same behavior as now. Stronger type safety.

 * `installationSources` is runtime value (JS object)
 * `InstallationSource` is TS type (`typeof installationSources`)
 * `ValueOf<InstallationSource>` is TS union type `'installed' | 'not_installed'`
 * Can access values directly as `installationSources.Installed` (JS) or `InstallationSource['Installed']` (TS)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlog kevinlog kevinlog approved these changes

Assignees

@jfsiii jfsiii

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jfsiii @elasticmachine @kibanamachine @kevinlog