-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Field formatters] Time suffix for duration formatter #76729
Conversation
Pinging @elastic/kibana-app-arch (Team:AppArch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been so long since I've touched this code so I don't really feel qualified to review this unless I refresh on how all these things work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
@elasticmachine merge upstream |
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, runs well too.
Users who don't set up the duration formatter are often confused by the units represented by the number, so adding a suffix is the easiest way to indicate the unit. Originally I considered adding abbreviated suffixes such as
ms
ands
, but instead I'm reusing the existing existing text labels for duration. The possible suffixes are translated. In English they are:Examples:
Closes #72762
Checklist
Delete any items that are not applicable to this PR.