-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM][Detection Engine] Speeds up value list imports by enabling streaming of files. #70685
[SIEM][Detection Engine] Speeds up value list imports by enabling streaming of files. #70685
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
…to stream-imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got a walkthrough of the streaming logic from @FrankHassanabad, and the code looks good!
I tested this against #67068, and it decreased import time of a 1.2kB file from 52s to 444ms. So yeah, this is an improvement to say the least 😉 .
}); | ||
|
||
readline.on('close', () => { | ||
this.push(null); | ||
}); | ||
} | ||
|
||
public _read(): void { | ||
// No operation but this is required to be implemented | ||
public _read(): void {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was gonna say we should leave the comment, but the typescript error generated if one removes this method should be straightforward 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Saw Ryland pulled down to test, so was just looking at the code. This is really awesome!
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/siem (Team:SIEM) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Summary
Checklist