[internal] Replace var with const/let in the root of ui #6882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was applied only to files in the root of the src/ui directory. This was an automatic replacement from var to let for any variable declaration that doubles as the initial assignment. Ultimately we want most of these to be converted to const, but that can happen in a future commit. For example: `var foo = 'bar';` becomes `let foo = 'var';` This was accomplished by replacing: find: `var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=` replace: `let $1$2=`
This change was applied only to files in the root of the src/ui directory. All instances of `let` were replaced with `const`, and then any instance that flagged the `no-const-assign` rule in the linter was put back.
|
LGTM |
|
@epixa Do we need to backport this? Some of the code has changed substantially and the backport doesn't seem too simple. If you want to reapply the transformations to the other branches I think that'd be the best way to go. Removing the other branches for now, as I don't really think it's worth the effort. |
|
See my comment on the other PR: #6881 (comment) |
epixa
added a commit
that referenced
this pull request
Apr 13, 2016
--------- **Commit 1:** [internal] Replace var with let in root of ui This change was applied only to files in the root of the src/ui directory. This was an automatic replacement from var to let for any variable declaration that doubles as the initial assignment. Ultimately we want most of these to be converted to const, but that can happen in a future commit. For example: `var foo = 'bar';` becomes `let foo = 'var';` This was accomplished by replacing: find: `var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=` replace: `let $1$2=` * Original sha: a6ed127 * Authored by Court Ewing <court@epixa.com> on 2016-04-12T21:50:00Z **Commit 2:** [internal] Replace let with const in root of ui This change was applied only to files in the root of the src/ui directory. All instances of `let` were replaced with `const`, and then any instance that flagged the `no-const-assign` rule in the linter was put back. * Original sha: 31a1e1a * Authored by Court Ewing <court@epixa.com> on 2016-04-12T21:55:25Z
elastic-jasper
added a commit
that referenced
this pull request
Apr 13, 2016
--------- **Commit 1:** [internal] Replace var with let in root of ui This change was applied only to files in the root of the src/ui directory. This was an automatic replacement from var to let for any variable declaration that doubles as the initial assignment. Ultimately we want most of these to be converted to const, but that can happen in a future commit. For example: `var foo = 'bar';` becomes `let foo = 'var';` This was accomplished by replacing: find: `var ([a-zA-Z_$][0-9a-zA-Z_$]*)(\s+)=` replace: `let $1$2=` * Original sha: a6ed127 * Authored by Court Ewing <court@epixa.com> on 2016-04-12T21:50:00Z **Commit 2:** [internal] Replace let with const in root of ui This change was applied only to files in the root of the src/ui directory. All instances of `let` were replaced with `const`, and then any instance that flagged the `no-const-assign` rule in the linter was put back. * Original sha: 31a1e1a * Authored by Court Ewing <court@epixa.com> on 2016-04-12T21:55:25Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was applied only to files in the root of the src/ui
directory.
All instances of var were replaced with let, and then all instances
of let that wouldn't flag the no-const-assign rule in the linter were
replaced with const.