[Regression] Histogram aggregation always shows an error message #63484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/plugins/data/public/plugin.ts # src/plugins/data/public/search/aggs/buckets/create_filter/ip_range.test.ts # src/plugins/data/public/search/search_service.ts
# Conflicts: # x-pack/plugins/maps/public/plugin.ts
lizozom
reviewed
Apr 22, 2020
src/legacy/core_plugins/kibana/public/discover/build_services.ts
Outdated
Show resolved
Hide resolved
lizozom
reviewed
Apr 22, 2020
src/legacy/core_plugins/kibana/public/discover/np_ready/angular/context/api/context.ts
Outdated
Show resolved
Hide resolved
lizozom
approved these changes
Apr 22, 2020
| fieldFormats: fieldFormatsServiceMock.createStartContract(), | ||
| notifications: notificationServiceMock.createStartContract(), | ||
| }); | ||
| const getInternalStartServices: GetInternalStartServicesFn = () => |
There was a problem hiding this comment.
//nit
I see this block repeating in every agg metric - maybe extract it for future flexibility
src/plugins/saved_objects_management/public/lib/resolve_saved_objects.ts
Outdated
Show resolved
Hide resolved
| private searchStrategyId?: string; | ||
| private parent?: SearchSource; | ||
| private requestStartHandlers: Array< | ||
| (searchSource: ISearchSource, options?: FetchOptions) => Promise<unknown> | ||
| (searchSource: SearchSource, options?: FetchOptions) => Promise<unknown> |
There was a problem hiding this comment.
Why did this change from ISearchSource?
There was a problem hiding this comment.
SearchSource is a correct type here
# Conflicts: # x-pack/plugins/maps/public/layers/sources/es_source/es_source.d.ts
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
Apr 22, 2020
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Apr 22, 2020
…stic#63484) * WIP [Regression] Histogram aggregation always shows an error message Closes: elastic#62624 * make getInternalStartServices private * fix ts issues * remove createSearchSource from static contract * fix some jest test * move searh_source to static contract * fix types * fix function tests * fix jest / add createStartServicesGetter * fix comments: saved_object_management * maps: fix PR comments * maps: update types * fix heck_published_api_changes * move searchSource into runtime contract * cleanup * fix ts error * cleanup * remove extra dependencies * fix Discover * fix Discover JEST * fix PR comments Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # src/plugins/data/public/public.api.md
alexwizp
added a commit
that referenced
this pull request
Apr 22, 2020
) (#64211) * WIP [Regression] Histogram aggregation always shows an error message Closes: #62624 * make getInternalStartServices private * fix ts issues * remove createSearchSource from static contract * fix some jest test * move searh_source to static contract * fix types * fix function tests * fix jest / add createStartServicesGetter * fix comments: saved_object_management * maps: fix PR comments * maps: update types * fix heck_published_api_changes * move searchSource into runtime contract * cleanup * fix ts error * cleanup * remove extra dependencies * fix Discover * fix Discover JEST * fix PR comments Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # src/plugins/data/public/public.api.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #62624
Summary
this PR closes a couple of issues related to
SearchSourceclass (public/search/search_source/search_source.ts).We shouldn't use
getters/gettersapproach for static contract. This PR solves this problem, and now we pass all the necessary services directly from all places whereSearchSourceshould be created.Important note:
We cannot add
SearchSourceto thesearchruntime contract because thesearchServiceis one of the required dependencies here.Checklist
Delete any items that are not applicable to this PR.
For maintainers