Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to 14.5.0 #48119

Merged
merged 5 commits into from
Oct 15, 2019
Merged

Upgrade EUI to 14.5.0 #48119

merged 5 commits into from
Oct 15, 2019

Conversation

thompsongl
Copy link
Contributor

14.5.0

  • Update Elastic-Charts to version 13.0.0 and updated the theme object accordingly (#2381)
  • Added new EuiColorStops component (#2360)
  • Added currency glyph to 'EuiIcon' (#2398)
  • Migrate EuiBreadcrumbs, EuiHeader etc, and EuiLink to TypeScript (#2391)
  • Added hasChildLabel prop to EuiFormRow to avoid duplicate labels (#2411)
  • Added component prop to EuiPageBody, switching the default from div to main (#2410)
  • Added focus state to EuiListGroupItem (#2406)
  • Added keyboardShorcut glyph to 'EuiIcon (#2413)
  • Improved a11y in EuiNavDrawer (#2417)
  • Improved a11y in EuiSuperDatePicker (#2426)

Bug fixes

  • Fixed EuiSelectable to accept programmatic updates to its options prop (#2390)
  • Fixed poor labeling in EuiSuperDatePicker (#2411)
  • Fixed EuiCodeEditor's ID to be dynamic between renders (#2411)
  • Fixed EuiCodeEditor to not render multiple labels for some inputs (#2411)
  • Fixed EuiBreadcrumbs improper use of useInnerText hook (#2425)

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 EUI labels Oct 14, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@thompsongl thompsongl marked this pull request as ready for review October 14, 2019 19:24
@thompsongl thompsongl requested review from a team as code owners October 14, 2019 19:24
@thompsongl thompsongl requested a review from a team October 14, 2019 19:24
@thompsongl thompsongl requested review from a team as code owners October 14, 2019 19:24
@thompsongl thompsongl requested a review from a team October 14, 2019 19:24
@thompsongl thompsongl requested a review from a team as a code owner October 14, 2019 19:24
joshdover
joshdover approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform changes LGTM

@thompsongl thompsongl requested a review from snide October 14, 2019 20:03
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

snide
snide approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran this locally and tested that the Chart changes are still good in Lens. Breadcrumbs look at they should. LGTM.

lizozom
lizozom approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App arch changes look good (only snapshot changed)

@legrego legrego self-requested a review October 15, 2019 13:08
@legrego legrego mentioned this pull request Oct 15, 2019
Closed
@thompsongl thompsongl merged commit 71b1bbd into elastic:master Oct 15, 2019
@legrego legrego removed their request for review October 15, 2019 15:13
@thompsongl thompsongl mentioned this pull request Oct 15, 2019
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Oct 15, 2019
@thompsongl
Upgrade EUI to 14.5.0 (elastic#48119)
66d45c3 
* eui 14.5.0

* snapshot updates

* update ChromeBreadcrumb interface

* change bad id selector to data-test-subj selector
sorenlouv
sorenlouv reviewed Oct 15, 2019
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes lgtm

thompsongl added a commit that referenced this pull request Oct 15, 2019
@thompsongl
Upgrade EUI to 14.5.0 (#48119) (#48241)
5a5b042 
* eui 14.5.0

* snapshot updates

* update ChromeBreadcrumb interface

* change bad id selector to data-test-subj selector
@myasonik myasonik mentioned this pull request Oct 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv left review comments

@snide snide snide approved these changes

@joshdover joshdover joshdover approved these changes

@lizozom lizozom lizozom approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thompsongl @elasticmachine @sorenlouv @snide @joshdover @lizozom