Add ability to select y-axis min and max values #3464

stormpython · 2015-03-26T16:14:10Z

Closes #354.

This pr adds the ability to select the y-axis min and max values.

…utton on change of min/max

…nal code around checking that the yAxis min and max values are valid

…s, adding functions for verifying user input, fixing failing tests

panda01 · 2015-04-07T17:14:35Z

src/kibana/components/vislib/lib/handler/types/point_series.js

@@ -20,7 +20,10 @@ define(function (require) {
      opts = opts || {};

      return function (vis) {
+        var isUserDefinedYAxisMin = (vis._attr.setYExtents.min);


Why have the parenthesis here?

panda01 · 2015-04-07T17:20:35Z

src/kibana/components/vislib/lib/y_axis.js

@@ -91,6 +109,16 @@ define(function (require) {
      return numeral(d).format('0.[0]a');
    };

+    YAxis.prototype.tickFormat = function (domain) {
+      if (this.isPercentage()) return d3.format('%');
+      if (domain[1] <= 100 && domain[0] >= -100 && !this.isPercentage()) return d3.format('n');


Perhaps a more descriptive if statement would be better suited here.

…w, etc

stormpython · 2015-04-08T20:07:09Z

@panda01 thanks for the earlier comments. I am putting the review tag on it now, so the rest is ready for review.

Conflicts: src/kibana/components/errors.js src/kibana/components/vislib/lib/y_axis.js src/kibana/plugins/vis_types/vislib/area.js src/kibana/plugins/vis_types/vislib/line.js

stormpython · 2015-04-08T21:45:47Z

@panda01 Update to my previous comment. Just resolved some conflicts after merging master. I will probably need to add some more tests to make sure things are sound. But please go ahead and review.

panda01 · 2015-04-09T14:49:02Z

src/kibana/plugins/vis_types/controls/vislib_basic_options.html

+    <div ng-show="vis.params.setYExtents.max">
+      <label>
+        y-max
+        <input type="number" step="0.1" ng-model="vis.params.yAxis.max" ng-required="vis.params.setYExtents.max">


You could use min here to make sure people can't input numbers < 0.

Just a suggestion since I see this

I don't actually won't to limit people from having values less than 0. You could have values where the min and the max values for the chart are both below zero.

It should only not be zero when the log scale is selected.

Whoops, well ignore that then.

Need some class="form-control" action here

panda01 · 2015-04-09T17:58:49Z

Perhaps for initial values for the min and max value for the y Axis we could use the current values?
Just to make it so that way the user doesn't have to type it in?

stormpython · 2015-04-09T20:06:17Z

@panda01 yeah, that was what I initially wanted to try, but I couldn't figure out how to get those values using ng-model, and after talking with @spalger, he didn't think that was a good idea. Or maybe I miss understood him.

In any case, I love that idea. If you have sometime to help me figure it out, I'd really appreciate it.

spalger · 2015-04-09T20:39:12Z

@stormpython @panda01 the vis options and the vislibVis object are very, very separate (intentionally). We might be able to figure out the y-bounds using the searchSource's history, but that won't take into account stacking or scaling, all in all I don't think it's worth it.

panda01 · 2015-04-20T13:59:52Z

This LGTM. After talking with @spalger, it definitely seems like adding the already calculated min and max, is a hassle.

This PR also calls for one more set of eyes.

w33ble · 2015-04-23T00:55:39Z

Maybe not a blocker, but it seems odd to show an axis error about the min value when the user hasn't supplied a max value.

panda01 · 2015-05-15T15:23:54Z

@rashidkpc I don't believe the issue regarding two clicks to validate the form is related to the pull at all. Here is that same issue when messing with agg.

panda01 · 2015-05-15T15:26:02Z

#3848 Should address the aforementioned issue with needing to validate twice

rashidkpc · 2015-05-15T15:28:40Z

I removed my comment about double validation, fix the tests and I think this is GTG if the clamping issue is solved.

stormpython · 2015-05-15T15:31:31Z

@rashidkpc the clamping issue should be solved in the last push. Also, in one of the tests, when I change 'function' to Function, the tests break. I confirmed that function is the output of the typeof operator, but not sure why it works in one case and not the other. All of what is mentioned here is in my latests push.

stormpython · 2015-05-15T15:35:03Z

@rashidkpc sorry, misread you note, making the corrections

stormpython · 2015-05-15T15:39:38Z

@rashidkpc on a second look, that doesn't seem to work either. Don't have time to figure out why this morning, so I will revert the changes and look into it later.

rashidkpc · 2015-05-15T20:31:47Z

Should be .to.be.a(Function) instead of .to.be(Function), note the .a()

stormpython · 2015-05-15T23:23:50Z

@rashidkpc thanks, made the corrections.

rashidkpc · 2015-05-18T14:53:23Z

This LGTM. Asking @panda01 to give it a final once over

panda01 · 2015-05-18T15:36:10Z

This looks really good. One thing though, when we check the checkbox to enable manual Y min, max we should disable the "Scale Y-Axis to Data Bounds" checkbox, to reduce confusion.

Besides that, this actually LGTM.

Add ability to select y-axis min and max values

julienbeclin · 2015-06-24T14:34:05Z

Hello !

How can we access to this new version ? Has it been added to 4.1?
Thanks

stormpython added 4 commits March 17, 2015 16:47

init commit, work in progress

e6656e4

adding ability to choose y-axis min and max, fixed issue with apply b…

b938d30

…utton on change of min/max

working through bugs/issues

bf3fe0d

small refactor

3d763e8

stormpython added the v4.1.0 label Mar 27, 2015

stormpython added 4 commits March 31, 2015 12:33

working through issues

7da716b

added ng-require directive to yAxis min and max input box and additio…

2493d74

…nal code around checking that the yAxis min and max values are valid

changing the flow

3c668bd

refactoring yAxis class, breaking out functions into smaller function…

158e54c

…s, adding functions for verifying user input, fixing failing tests

panda01 self-assigned this Apr 6, 2015

panda01 reviewed Apr 7, 2015
View reviewed changes

stormpython mentioned this pull request Apr 7, 2015

Adds ability to smooth lines for line and area charts #3273

Merged

panda01 reviewed Apr 7, 2015
View reviewed changes

adding tests, correcting syntax, making changes according to pr revie…

b27105e

…w, etc

stormpython added the review label Apr 8, 2015

Merge branch 'master' into fixed_scales

3985fb2

Conflicts: src/kibana/components/errors.js src/kibana/components/vislib/lib/y_axis.js src/kibana/plugins/vis_types/vislib/area.js src/kibana/plugins/vis_types/vislib/line.js

stormpython added 2 commits April 8, 2015 22:20

fixing broken tests and conflicts from merge with master

30c1b32

Merge branch 'master' into fixed_scales

6c95166

panda01 reviewed Apr 9, 2015
View reviewed changes

Merge branch 'master' into fixed_scales

36d34ae

panda01 assigned w33ble and unassigned panda01 Apr 20, 2015

rashidkpc unassigned w33ble Apr 24, 2015

correcting issues based on pr reviews

aefa3c7

correcting tests

fcf70bd

reverting changes to tests

bbaca6e

rashidkpc mentioned this pull request May 15, 2015

Adds updated doc material for the 4.1 release of Kibana #3813

Merged

making testing corrections

d3bca41

stormpython assigned rashidkpc and unassigned stormpython May 18, 2015

Merge branch 'master' into fixed_scales

c7e8779

rashidkpc assigned panda01 and unassigned rashidkpc May 18, 2015

panda01 assigned stormpython and unassigned panda01 May 18, 2015

rashidkpc added the blocker label May 18, 2015

disable set data bounds option when set y extents is checked

0a55558

stormpython assigned panda01 and unassigned stormpython May 18, 2015

rashidkpc added a commit that referenced this pull request May 18, 2015

Merge pull request #3464 from stormpython/fixed_scales

0128aa9

Add ability to select y-axis min and max values

rashidkpc merged commit 0128aa9 into elastic:master May 18, 2015

stormpython deleted the fixed_scales branch June 19, 2015 20:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to select y-axis min and max values #3464

Add ability to select y-axis min and max values #3464

stormpython commented Mar 26, 2015

panda01 Apr 7, 2015

panda01 Apr 7, 2015

stormpython commented Apr 8, 2015

stormpython commented Apr 8, 2015

panda01 Apr 9, 2015

stormpython Apr 9, 2015

panda01 Apr 9, 2015

rashidkpc Apr 24, 2015

panda01 commented Apr 9, 2015

stormpython commented Apr 9, 2015

spalger commented Apr 9, 2015

panda01 commented Apr 20, 2015

w33ble commented Apr 23, 2015

panda01 commented May 15, 2015

panda01 commented May 15, 2015

rashidkpc commented May 15, 2015

stormpython commented May 15, 2015

stormpython commented May 15, 2015

stormpython commented May 15, 2015

rashidkpc commented May 15, 2015

stormpython commented May 15, 2015

rashidkpc commented May 18, 2015

panda01 commented May 18, 2015

julienbeclin commented Jun 24, 2015

Add ability to select y-axis min and max values #3464

Add ability to select y-axis min and max values #3464

Conversation

stormpython commented Mar 26, 2015

panda01 Apr 7, 2015

Choose a reason for hiding this comment

panda01 Apr 7, 2015

Choose a reason for hiding this comment

stormpython commented Apr 8, 2015

stormpython commented Apr 8, 2015

panda01 Apr 9, 2015

Choose a reason for hiding this comment

stormpython Apr 9, 2015

Choose a reason for hiding this comment

panda01 Apr 9, 2015

Choose a reason for hiding this comment

rashidkpc Apr 24, 2015

Choose a reason for hiding this comment

panda01 commented Apr 9, 2015

stormpython commented Apr 9, 2015

spalger commented Apr 9, 2015

panda01 commented Apr 20, 2015

w33ble commented Apr 23, 2015

panda01 commented May 15, 2015

panda01 commented May 15, 2015

rashidkpc commented May 15, 2015

stormpython commented May 15, 2015

stormpython commented May 15, 2015

stormpython commented May 15, 2015

rashidkpc commented May 15, 2015

stormpython commented May 15, 2015

rashidkpc commented May 18, 2015

panda01 commented May 18, 2015

julienbeclin commented Jun 24, 2015