-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapsible sidebar #3185
Collapsible sidebar #3185
Conversation
@panda01 this looks good to me functionally. Stylistically (is that a word?), I think the width of the 'sidebar-collapser' feels a little tight and covers up the right edge of the 'sidebar-list'. Maybe it could be styled like the tab to open and close the 'spy panel'. |
…the top of the side panel
@panda01 This LGTM, but I wonder when the screen size is reduced whether there is a need for the collapsible sidebar anymore. For example: In this situation the side bar is already collapsed. So, I do not think there is a need for the collapsible directive applied to the sidebar. See below. But it's certainly not a blocker. May want to ask @rashidkpc or @spalger. |
… the screen is too small, and hides the entire sidebar when it's collapsed and too small
Smooth thanks for the review, I put a solution that I believe will work! |
LGTM. Feel free to merge this. |
Added a directive for collapsing sidebars. Closes #3037.