[APM] Fix Deep Links Cypress Flaky Test #206000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
crespocarlos
reviewed
Jan 9, 2025
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7679[✅] APM - Cypress: 25/25 tests passed. |
Hey @crespocarlos, I forgot to do that, ran them one hour ago, and they have passed 🚀 |
crespocarlos
approved these changes
Jan 9, 2025
jennypavlova
approved these changes
Jan 9, 2025
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12691302434 |
💚 Build Succeeded
Metrics [docs]
History
cc @rmyz |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 9, 2025
## Summary Closes elastic#205936 This PR aims to solve the flakiness of deep_links.cy test. - Instead of doing everything under 2 tests, we run a test for each assertion and clean everything up. - Ensures scroll div has content to be able to scroll - scrolls to center or bottom depending on the position (cherry picked from commit 45f3241)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 9, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[APM] Fix Deep Links Cypress Flaky Test (#206000)](#206000) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-01-09T13:54:11Z","message":"[APM] Fix Deep Links Cypress Flaky Test (#206000)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/205936\n\nThis PR aims to solve the flakiness of deep_links.cy test.\n\n- Instead of doing everything under 2 tests, we run a test for each\nassertion and clean everything up.\n- Ensures scroll div has content to be able to scroll\n- scrolls to center or bottom depending on the position","sha":"45f3241db0bd06a264a94d8cfd104bf4057db77e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","apm","backport:prev-minor","Team:obs-ux-infra_services"],"title":"[APM] Fix Deep Links Cypress Flaky Test","number":206000,"url":"https://github.com/elastic/kibana/pull/206000","mergeCommit":{"message":"[APM] Fix Deep Links Cypress Flaky Test (#206000)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/205936\n\nThis PR aims to solve the flakiness of deep_links.cy test.\n\n- Instead of doing everything under 2 tests, we run a test for each\nassertion and clean everything up.\n- Ensures scroll div has content to be able to scroll\n- scrolls to center or bottom depending on the position","sha":"45f3241db0bd06a264a94d8cfd104bf4057db77e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206000","number":206000,"mergeCommit":{"message":"[APM] Fix Deep Links Cypress Flaky Test (#206000)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/205936\n\nThis PR aims to solve the flakiness of deep_links.cy test.\n\n- Instead of doing everything under 2 tests, we run a test for each\nassertion and clean everything up.\n- Ensures scroll div has content to be able to scroll\n- scrolls to center or bottom depending on the position","sha":"45f3241db0bd06a264a94d8cfd104bf4057db77e"}}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
Zacqary
pushed a commit
to Zacqary/kibana
that referenced
this pull request
Jan 9, 2025
## Summary Closes elastic#205936 This PR aims to solve the flakiness of deep_links.cy test. - Instead of doing everything under 2 tests, we run a test for each assertion and clean everything up. - Ensures scroll div has content to be able to scroll - scrolls to center or bottom depending on the position
This was referenced Jan 10, 2025
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
## Summary Closes elastic#205936 This PR aims to solve the flakiness of deep_links.cy test. - Instead of doing everything under 2 tests, we run a test for each assertion and clean everything up. - Ensures scroll div has content to be able to scroll - scrolls to center or bottom depending on the position
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
## Summary Closes elastic#205936 This PR aims to solve the flakiness of deep_links.cy test. - Instead of doing everything under 2 tests, we run a test for each assertion and clean everything up. - Ensures scroll div has content to be able to scroll - scrolls to center or bottom depending on the position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #205936
This PR aims to solve the flakiness of deep_links.cy test.