Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ObsUX] Unskip failing test #196727

Merged
merged 6 commits into from
Oct 24, 2024
Merged

[ObsUX] Unskip failing test #196727

merged 6 commits into from
Oct 24, 2024

Conversation

MiriamAparicio
Copy link
Contributor

Closes #191961

@MiriamAparicio MiriamAparicio added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.16.0 labels Oct 17, 2024
@MiriamAparicio MiriamAparicio requested a review from a team as a code owner October 17, 2024 15:26
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@MiriamAparicio
Copy link
Contributor Author

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7168

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7168

[❌] APM - Cypress: 0/50 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7181

[❌] APM - Cypress: 8/50 tests passed.

see run history

@MiriamAparicio MiriamAparicio mentioned this pull request Oct 23, 2024
Open
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 23, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 5051614
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-196727-5051614e380c

Metrics [docs]

✅ unchanged

History

rmyz
rmyz reviewed Oct 24, 2024
View reviewed changes
...observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts

describe('Transaction details', () => {
// flaky
describe.skip('Transaction details', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? Yesterday I skipped 2 flaky tests from this suite

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to skip the whole test suite as we don't know exactly what's the issue here

cauemarcondes
cauemarcondes approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiriamAparicio MiriamAparicio merged commit bd11d1a into elastic:main Oct 24, 2024
25 checks passed
@MiriamAparicio MiriamAparicio deleted the 191961-fix-skipped-tests branch October 24, 2024 10:03
@kibanamachine kibanamachine mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmyz rmyz rmyz left review comments

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Failed Tests][Unsupported FTRs] APM Cypress && Synthetics Tests
5 participants
@MiriamAparicio @elasticmachine @kibanamachine @rmyz @cauemarcondes