Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Update grammars #190289

Merged
merged 2 commits into from
Aug 12, 2024
Merged

[ES|QL] Update grammars #190289

merged 2 commits into from
Aug 12, 2024

Conversation

kibanamachine
Copy link
Contributor

This PR updates the ES|QL grammars (lexer and parser) to match the latest version in Elasticsearch.

@kibanamachine kibanamachine requested a review from a team as a code owner August 12, 2024 04:10
@kibanamachine kibanamachine added release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana labels Aug 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

stratoula
stratoula approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to do some changes to the tests due to the introduction of the new command. LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.3MB 3.3MB +2.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit fd9805d into main Aug 12, 2024
19 checks passed
@stratoula stratoula deleted the esql_grammar_sync_1723435797 branch August 12, 2024 08:06
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kibanamachine @elasticmachine @kibana-ci @stratoula