Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variables to ?t_start and ?t_end #190264

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

stratoula
Copy link
Contributor

Summary

Renames the variables from ?start to ?t_start and ?end to ?t_end

Naming is hard so bare with us 😅 (I think this will be the last change)

@stratoula
Copy link
Contributor Author

/ci

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels Aug 12, 2024
@stratoula
Copy link
Contributor Author

Ok we decided in favor, sorry for the noice, I am merging as you have already approved.

@stratoula stratoula marked this pull request as ready for review August 12, 2024 05:41
@stratoula stratoula requested review from a team as code owners August 12, 2024 05:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula merged commit eaf4bb0 into elastic:main Aug 12, 2024
46 of 48 checks passed
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 12, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #16 / apis ESQL sync error messages Using string field type: text and number field type: integer Checking error messages
  • [job] [logs] FTR Configs #16 / apis ESQL sync error messages Using string field type: text and number field type: integer Checking error messages
  • [job] [logs] FTR Configs #47 / EPM Endpoints TESTME Installing custom integrations Correctly sets up index templates to create an ECS compliant mapping
  • [job] [logs] FTR Configs #47 / EPM Endpoints TESTME Installing custom integrations Correctly sets up index templates to create an ECS compliant mapping

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 564.1KB 564.1KB +8.0B
apm 3.5MB 3.5MB +8.0B
dashboard 533.6KB 533.6KB +8.0B
dataVisualizer 799.6KB 799.6KB +16.0B
discover 839.5KB 839.5KB +8.0B
investigateApp 214.6KB 214.6KB +4.0B
lens 1.5MB 1.5MB +16.0B
maps 3.0MB 3.0MB +16.0B
ml 4.6MB 4.6MB +8.0B
observabilityAIAssistantApp 150.2KB 150.2KB +4.0B
securitySolution 20.7MB 20.7MB +40.0B
slo 911.6KB 911.6KB +8.0B
stackAlerts 75.6KB 75.6KB +4.0B
total +148.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 418.1KB 418.1KB +8.0B
discover 47.7KB 47.7KB +8.0B
kbnUiSharedDeps-srcJs 3.3MB 3.3MB +4.0B
total +20.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula changed the title Rename variables 2 Rename variables to ?t_start and ?t_end Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants