Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15] [Annotations listing page] unskip flaky test (#190053) #190134

Merged
merged 1 commit into from
Aug 8, 2024
Merged

[8.15] [Annotations listing page] unskip flaky test (#190053) #190134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions test/functional/apps/visualize/group3/_annotation_listing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const retry = getService('retry');
const log = getService('log');

// Failing: See https://github.com/elastic/kibana/issues/168281
describe.skip('annotation listing page', function () {
describe('annotation listing page', function () {
before(async function () {
await kibanaServer.importExport.load(
'test/functional/fixtures/kbn_archiver/annotation_listing_page_search'
Expand Down Expand Up @@ -49,8 +48,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await listingTable.clearSearchFilter();
});

// FLAKY: https://github.com/elastic/kibana/issues/168281
describe.skip('by text', () => {
describe('by text', () => {
it('matches on the first word', async function () {
await retry.try(async () => {
await listingTable.searchForItemWithName('search');
Expand Down
6 changes: 5 additions & 1 deletion test/functional/services/listing_table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export class ListingTableService extends FtrService {
}

public async waitUntilTableIsLoaded() {
return this.retry.try(async () => {
await this.retry.try(async () => {
const isLoaded = await this.find.existsByDisplayedByCssSelector(
'[data-test-subj="itemsInMemTable"]:not(.euiBasicTable-loading)'
);
Expand Down Expand Up @@ -264,6 +264,10 @@ export class ListingTableService extends FtrService {

await searchFilter.type(name);
await this.common.pressEnterKey();
const filterValue = await this.getSearchFilterValue();
if (filterValue !== name) {
throw new Error(`the input value has not updated properly`);
}
});

await this.waitUntilTableIsLoaded();
Expand Down
1 change: 1 addition & 0 deletions x-pack/test/functional/apps/lens/group2/fields_list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await fieldEditor.typeScript("emit('abc')");
await fieldEditor.save();
await PageObjects.header.waitUntilLoadingHasFinished();
await testSubjects.missingOrFail('fieldEditor');
});
});
it('should show all fields as available', async () => {
Expand Down