Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OnWeek][ObsUX] Add fields to hosts in synthtrace to improve data generation #187147

Conversation

MiriamAparicio
Copy link
Contributor

Summary

After improving the synthtrace data creation for containers we were able to add more specific tests for container view, the aim of this spacetime is to add some improvements to hosts so we can in the future use synthtrace for testing

What was done

First I thought that adding event.dataset was needed to get the metadata, or make the request work, as I did for containers, but in containers was needed not because of the metadata query itself but the integration check to know if we need to display k8s or docker metrics.
I simplified the scenarios and data generation in the tests, adding the metadata fields we need in the synthtrace clients for host and docker and k8s containers, the values of the metadata fields doesn't need to change for different scenarios, so it's ok to have them set in the client.

@MiriamAparicio MiriamAparicio added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.15.0 labels Jun 28, 2024
@MiriamAparicio MiriamAparicio requested review from a team as code owners June 28, 2024 11:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jun 28, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 30, 2024

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 (code review only)
Do we test with the existing containers scenario or do we need another one?

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 3, 2024

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@MiriamAparicio
Copy link
Contributor Author

Do we test with the existing containers scenario or do we need another one?

@jennypavlova not sure what do you mean here, the existing scenarios for containers and hosts should be enough for testing that the metadata fields are displayed on the summaries, I did not add all the possible metadata fields that can be shown on the metadata tab, as I don't think it's necessary for testing

@MiriamAparicio MiriamAparicio merged commit 7274f44 into elastic:main Jul 3, 2024
20 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 3, 2024
@MiriamAparicio MiriamAparicio deleted the space-time-syntrace-improvements-hosts branch July 3, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants