-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OnWeek][ObsUX] Add fields to hosts in synthtrace to improve data generation #187147
[OnWeek][ObsUX] Add fields to hosts in synthtrace to improve data generation #187147
Conversation
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯 (code review only)
Do we test with the existing containers scenario or do we need another one?
💚 Build Succeeded
Metrics [docs]
History |
@jennypavlova not sure what do you mean here, the existing scenarios for containers and hosts should be enough for testing that the metadata fields are displayed on the summaries, I did not add all the possible metadata fields that can be shown on the metadata tab, as I don't think it's necessary for testing |
Summary
After improving the synthtrace data creation for containers we were able to add more specific tests for container view, the aim of this spacetime is to add some improvements to hosts so we can in the future use synthtrace for testing
What was done
First I thought that adding
event.dataset
was needed to get the metadata, or make the request work, as I did for containers, but in containers was needed not because of the metadata query itself but the integration check to know if we need to display k8s or docker metrics.I simplified the scenarios and data generation in the tests, adding the metadata fields we need in the synthtrace clients for host and docker and k8s containers, the values of the metadata fields doesn't need to change for different scenarios, so it's ok to have them set in the client.