Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saved query update test #173576

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Fix saved query update test #173576

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
743d29a
Fix saved query update test
lukasolson Dec 18, 2023
0fae25b
Merge branch 'main' into fix/saved-query-update
lukasolson Jan 3, 2024
28e8d68
Don't rely on toasts
lukasolson Jan 3, 2024
d70c32e
Close saved query dialog
lukasolson Jan 3, 2024
770752a
Merge branch 'main' into fix/saved-query-update
lukasolson Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions x-pack/test/functional/apps/discover/saved_queries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,13 @@
* 2.0.
*/

import expect from '@kbn/expect';
import { FtrProviderContext } from '../../ftr_provider_context';

export default function ({ getService, getPageObjects }: FtrProviderContext) {
const browser = getService('browser');
const esArchiver = getService('esArchiver');
const kibanaServer = getService('kibanaServer');
const spaces = getService('spaces');
const toasts = getService('toasts');
const PageObjects = getPageObjects([
'common',
'discover',
Expand All @@ -26,8 +24,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const savedQueryName = 'shared-saved-query';
const destinationSpaceId = 'nondefaultspace';

// Failing: See https://github.com/elastic/kibana/issues/173094
describe.skip('Discover Saved Queries', () => {
describe('Discover Saved Queries', () => {
before('initialize tests', async () => {
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/logstash_functional');
await kibanaServer.importExport.load(
Expand All @@ -53,6 +50,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
// Navigate to Discover & create a saved query
await PageObjects.common.navigateToApp('discover');
await queryBar.setQuery('response:200');
await queryBar.submitQuery();
await savedQueryManagementComponent.saveNewQuery(savedQueryName, '', true, false);
await savedQueryManagementComponent.savedQueryExistOrFail(savedQueryName);
await savedQueryManagementComponent.closeSavedQueryManagementComponent();
Expand All @@ -76,24 +74,26 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});

it('updates a saved query', async () => {
const name = `${savedQueryName}-update`;

// Navigate to Discover & create a saved query
await PageObjects.common.navigateToApp('discover');
await queryBar.setQuery('response:200');
await savedQueryManagementComponent.saveNewQuery(savedQueryName, '', true, false);
await savedQueryManagementComponent.savedQueryExistOrFail(savedQueryName);
await queryBar.submitQuery();
await savedQueryManagementComponent.saveNewQuery(name, '', true, false);
await savedQueryManagementComponent.savedQueryExistOrFail(name);
await savedQueryManagementComponent.closeSavedQueryManagementComponent();

// Navigate to Discover & create a saved query
// Update the saved query
await queryBar.setQuery('response:404');
await queryBar.submitQuery();
await savedQueryManagementComponent.updateCurrentlyLoadedQuery('', true, false);

// Expect to see a success toast
const successToast = await toasts.getToastElement(1);
const successText = await successToast.getVisibleText();
expect(successText).to.equal(`Your query "${savedQueryName}" was saved`);

// Navigate to Discover ensure updated query exists
await PageObjects.common.navigateToApp('discover');
await savedQueryManagementComponent.deleteSavedQuery(savedQueryName);
await savedQueryManagementComponent.savedQueryExistOrFail(name);
await savedQueryManagementComponent.closeSavedQueryManagementComponent();
await savedQueryManagementComponent.deleteSavedQuery(name);
});
});
});
Expand Down