Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Fix scheduling callout and restrict width #137255

Merged
merged 1 commit into from
Jul 27, 2022
Merged

[Enterprise Search] Fix scheduling callout and restrict width #137255

merged 1 commit into from
Jul 27, 2022

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Jul 27, 2022 •
edited by kibanamachine
Loading

This changes the info text on the scheduling page, to a callout and applies a width restriction to all enterprise search content pages.

Screenshot 2022-07-27 at 11 13 58

Screenshot 2022-07-27 at 11 13 42

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0 labels Jul 27, 2022
@sphilipse sphilipse requested a review from a team July 27, 2022 09:16
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #20 / Spaces app Spaces Search spaces in popover search for "ce-1 name" and find one space

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.5MB 1.5MB +640.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit 37d5dd6 into elastic:main Jul 27, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.5 The branch "8.5" does not exist

Manual backport

To create the backport manually run:

node scripts/backport --pr 137255

Questions ?

Please refer to the Backport tool documentation

@sphilipse sphilipse removed the v8.5.0 label Jul 27, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byronhulcher byronhulcher byronhulcher approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sphilipse @kibana-ci @kibanamachine @byronhulcher