Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Use same action_id for all batches in an upgrade #136663

Merged
merged 1 commit into from
Jul 20, 2022
Merged

[Fleet] Use same action_id for all batches in an upgrade #136663

merged 1 commit into from
Jul 20, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jul 19, 2022 •
edited
Loading

Summary

Resolve #135801

The .fleet-actions index was build to allow the same action_id for different document, it's already used by osquery. We can use the same action_id for all the batches of an upgrade.

How to test?

  1. create a bunch of upgradeable agents
  2. Trigger an upgrade with a small batchSize
POST kbn:/api/fleet/agents/bulk_upgrade
{
  "agents": "*",
  "version": "8.4.0-SNAPSHOT",
  "batchSize": 1
}
  1. You can see there is multiple fleet actions (one per agent)
  2. but only one upgrade toast

Screen Shot 2022-07-19 at 1 03 08 PM

@juliaElastic if it make sense to you I can add some automated test for that.

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 labels Jul 19, 2022
@nchaulet nchaulet requested a review from a team as a code owner July 19, 2022 17:07
@nchaulet nchaulet self-assigned this Jul 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet mentioned this pull request Jul 19, 2022
Closed
@nchaulet nchaulet changed the title [Fleet] Use same action_id for all batches in an uprade [Fleet] Use same action_id for all batches in an upgrade Jul 19, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

kpollich
kpollich approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@juliaElastic
Copy link
Contributor

@nchaulet thanks for fixing, I didn't know it is already supported

juliaElastic
juliaElastic approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nchaulet nchaulet merged commit 030ff82 into elastic:main Jul 20, 2022
@nchaulet nchaulet deleted the feature-same-action-id-upgrade-batches branch July 20, 2022 13:31
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@nchaulet nchaulet

Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Improve UI for agent upgrade in batches to hide complexity
6 participants
@nchaulet @elasticmachine @kibana-ci @juliaElastic @kpollich @kibanamachine