Remove the es_admin proxy #13000
Merged
Remove the es_admin proxy #13000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ebbc8b to
47f6d82
Compare
d83ae6e to
b9e8897
Compare
Saved object access is now handled through the saved object client rather than by making direct requests to the admin cluster through a proxy. The indices module and scanner module were both still relying on the proxy, so temporary "legacy" endpoints have been created for their specific use-cases. We should add more purposeful endpoints to the public API in the future to replace these. The admin cluster itself is still readily available on the server and should still be used for all requests for internal kibana indices.
|
I think a green build is blocked by #13014, or at least I can't get further in the tests than the issue that PR is fixing, but it should be good for review otherwise. |
tylersmalley
approved these changes
Jul 20, 2017
|
Merged master since #13014 went in |
Bargs
added a commit
that referenced
this pull request
Aug 10, 2017
The angular service was removed in #13000
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Aug 10, 2017
…3449) The angular service was removed in elastic#13000
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Aug 10, 2017
…3449) The angular service was removed in elastic#13000
This was referenced Aug 10, 2017
Bargs
added a commit
that referenced
this pull request
Aug 10, 2017
Bargs
added a commit
that referenced
this pull request
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saved object access is now handled through the saved object client
rather than by making direct requests to the admin cluster through a
proxy. The indices module and scanner module were both still relying on
the proxy, so temporary "legacy" endpoints have been created for their
specific use-cases. We should add more purposeful endpoints to the
public API in the future to replace these.
The admin cluster itself is still readily available on the server and
should still be used for all requests for internal kibana indices.