-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug where loaded event is not sent when no user ID #106090
Conversation
Pinging @elastic/kibana-core (Team:Core) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we should also have a test that will ensure this bug doesn't happen again. I'm not exactly sure where to add that, besides maybe trying to add one to the cloud_integration
test we recently enabled?
I don't have access to the FS test account anymore and could only do a quick code review.
The bug fix itself LGTM, we can discuss adding a test as a follow up.
I'm actually not sure a good way to test this. There is a user event API available, but in this case we can't use it directly because we don't have a user ID to hit the API with. It's possible there's some workaround or we can try to go the mocking route which is likely easier. |
Summary
Follow up to #102390
Fixes code that was returning early when no user ID was available. This ensures that the loaded event is still sent. Only applies to Elastic Cloud deployments where this is enabled.