[Enterprise Search] Test coverage pass #103406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: some test helpers are no longer being used but might be some day - e.g., shallowWithIntl will be used on the beta badge
- since we're not iterating over productNames, no need for it to be an array - it can be written more clearly in string union format
- Since KibanaLogic is setting `|| {}` fallbacks in any case, I've opted to remove them in this file and let fallbacks be handled there
- Fixed typing to make it clear plugins can be undefined (i.e., disabled/optional, etc) in props + reorganize w/ comments
- KibanaValues requires an Omit to override props types
- Fix test failing locally due to timezones by increasing the timezone offset - Cover missing branch line by adding a domain with no `lastCrawl` - Remove unnecessary extra beforeEach with dupe re-shallow/mounts - move getTable helper to its most relevant block (it's not being used in the generic column content checks, only in the actions column suite)
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
cee-chen
pushed a commit
to cee-chen/kibana
that referenced
this pull request
Jun 28, 2021
* Do not collect code coverage on test_helpers
Note: some test helpers are no longer being used but might be some day - e.g., shallowWithIntl will be used on the beta badge
* Fix uncovered type line
- since we're not iterating over productNames, no need for it to be an array - it can be written more clearly in string union format
* Fix branch coverage on index.tsx
- Since KibanaLogic is setting `|| {}` fallbacks in any case, I've opted to remove them in this file and let fallbacks be handled there
- Fixed typing to make it clear plugins can be undefined (i.e., disabled/optional, etc) in props + reorganize w/ comments
- KibanaValues requires an Omit to override props types
* Crawler DomainsTable test coverage/improvements
- Fix test failing locally due to timezones by increasing the timezone offset
- Cover missing branch line by adding a domain with no `lastCrawl`
- Remove unnecessary extra beforeEach with dupe re-shallow/mounts
- move getTable helper to its most relevant block (it's not being used in the generic column content checks, only in the actions column suite)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
# x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/domains_table.test.tsx
cee-chen
pushed a commit
that referenced
this pull request
Jun 28, 2021
* Do not collect code coverage on test_helpers
Note: some test helpers are no longer being used but might be some day - e.g., shallowWithIntl will be used on the beta badge
* Fix uncovered type line
- since we're not iterating over productNames, no need for it to be an array - it can be written more clearly in string union format
* Fix branch coverage on index.tsx
- Since KibanaLogic is setting `|| {}` fallbacks in any case, I've opted to remove them in this file and let fallbacks be handled there
- Fixed typing to make it clear plugins can be undefined (i.e., disabled/optional, etc) in props + reorganize w/ comments
- KibanaValues requires an Omit to override props types
* Crawler DomainsTable test coverage/improvements
- Fix test failing locally due to timezones by increasing the timezone offset
- Cover missing branch line by adding a domain with no `lastCrawl`
- Remove unnecessary extra beforeEach with dupe re-shallow/mounts
- move getTable helper to its most relevant block (it's not being used in the generic column content checks, only in the actions column suite)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
# x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/domains_table.test.tsx
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 28, 2021
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (253 commits) [Enterprise Search] Test coverage pass (elastic#103406) [App Search] Success toast polish pass (elastic#103410) Role mappings: remove deprecated reset copy (elastic#103411) [Fleet] Add a message when log collection is disabled on the log details page (elastic#103166) [Query] Remove es query dependency on format.convert (elastic#103174) Home & Kibana Overview Page Template Update (elastic#103003) [ML] Converts management app jobs list pages to new layout (elastic#103117) Allow additive csp configuration (elastic#102059) [Lens] Document common formulas in product and add formula tutorial (elastic#103154) [Lens] Enable actions on Lens Embeddable (elastic#102038) [Osquery] Return proper indices permissions for osquery_manager package (elastic#103363) Dashboard locator (elastic#102854) Maps locators (elastic#102810) [Fleet] Add support for constant_keyword "value" in package field definitions (elastic#103000) [Maps] Add capability to delete features from layer & index (elastic#103145) [Security Solution] Correct linux OS lookup for Endpoint Exceptions (elastic#103038) [Enterprise Search] Add notices for deactivated users and SMTP callout (elastic#103285) [canvas] Reduce bundle size by combining SCSS imports (elastic#102822) [Enterprise Search] Final KibanaPageTemplate cleanup (elastic#103355) [docs][migrations v2] Update SO migration docs to include removal of index write block when handling corrupt SOs. (elastic#103014) ...
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 28, 2021
…-policy-2 * 'master' of github.com:elastic/kibana: (190 commits) [Enterprise Search] Test coverage pass (elastic#103406) [App Search] Success toast polish pass (elastic#103410) Role mappings: remove deprecated reset copy (elastic#103411) [Fleet] Add a message when log collection is disabled on the log details page (elastic#103166) [Query] Remove es query dependency on format.convert (elastic#103174) Home & Kibana Overview Page Template Update (elastic#103003) [ML] Converts management app jobs list pages to new layout (elastic#103117) Allow additive csp configuration (elastic#102059) [Lens] Document common formulas in product and add formula tutorial (elastic#103154) [Lens] Enable actions on Lens Embeddable (elastic#102038) [Osquery] Return proper indices permissions for osquery_manager package (elastic#103363) Dashboard locator (elastic#102854) Maps locators (elastic#102810) [Fleet] Add support for constant_keyword "value" in package field definitions (elastic#103000) [Maps] Add capability to delete features from layer & index (elastic#103145) [Security Solution] Correct linux OS lookup for Endpoint Exceptions (elastic#103038) [Enterprise Search] Add notices for deactivated users and SMTP callout (elastic#103285) [canvas] Reduce bundle size by combining SCSS imports (elastic#102822) [Enterprise Search] Final KibanaPageTemplate cleanup (elastic#103355) [docs][migrations v2] Update SO migration docs to include removal of index write block when handling corrupt SOs. (elastic#103014) ... # Conflicts: # x-pack/plugins/reporting/server/lib/store/store.test.ts # x-pack/plugins/reporting/server/lib/store/store.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses a few remaining uncovered lines when running
sh jest.shon our plugin. Follow along by commit and read the full commit messages - I should have explained the rationale for every change there.(Note to self: I think this will need a manual backport since Crawler domain stuff isn't yet on the 7.x branch)
Before
After
BTW - here's our total tests stats plugin-wide! WOW, y'all.
Checklist