Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Use "Integrations" breadcrumb in "Add integrations" #103227

Conversation

jloleysens
Copy link
Contributor

Summary

When adding a new integration to an agent policy the breadcrumb should reflect that it is in the "Integrations" context.

How to test

Assuming you have followed in-app instructions for setting up fleet. Follow both of the following flows and confirm that the breadcrumbs look correct:

First flow

  1. Go to fleet
  2. Go to "Agent policies"
  3. Select an existing policy, or create a new one
  4. Select "Add integration"
  5. In the integrations UI, select a package and select "Add "
  6. Confirm that the breadcrumbs on this screen look correct

Second flow

  1. Go to integrations
  2. Select a package and select "Add "
  3. Confirm that the breadcrumbs on this screen look correct

Screenshots

Screenshot 2021-06-24 at 11 43 57

@jloleysens jloleysens added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 24, 2021
@jloleysens jloleysens requested a review from kpollich June 24, 2021 09:59
@jloleysens jloleysens requested a review from a team as a code owner June 24, 2021 09:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 691.9KB 691.6KB -313.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit 8a422fd into elastic:master Jun 24, 2021
@jloleysens jloleysens deleted the fleet/fix-create-policy-package-breadcrumb branch June 24, 2021 15:01
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 24, 2021
…103227)

* update the UI breadcrumbs in create policy package to always look like it came from integrations

* added comment about the removal of a path from fleet

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 24, 2021
…#103305)

* update the UI breadcrumbs in create policy package to always look like it came from integrations

* added comment about the removal of a path from fleet

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants