Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto interval filter building #102086

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Jun 14, 2021

Fixes #91481

The interval param of a histogram agg can be "auto" as well - in this case building the filter won't work. The correct value is stored in used_interval if the agg has been used to actually fetch data. This PR makes sure to use this information if available.

Can be reproduced in Visualize - create a bar chart with an auto number histogram on the x axis and click a bar.

@flash1293 flash1293 added release_note:fix v8.0.0 Team:AppServices v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 14, 2021
@flash1293 flash1293 marked this pull request as ready for review June 15, 2021 07:30
@flash1293 flash1293 requested a review from a team as a code owner June 15, 2021 07:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 831.0KB 831.1KB +81.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM 👍

@flash1293 flash1293 merged commit f65d450 into elastic:master Jun 17, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 17, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 17, 2021
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
@timroes timroes added the Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) label Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) release_note:fix v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter building fails for auto number histogram
5 participants