Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Clickjacking" on mouse hover over Discover table cell (not legacy table) #99312

Closed
ypid-geberit opened this issue May 5, 2021 · 6 comments
Closed
Labels
blocked EUI Feature:Discover Discover Application impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@ypid-geberit
Copy link

Kibana version:
7.12.1. (7.12.0 is also affected).

Elasticsearch version:
7.12.1

Server OS version:
SLES

Browser version:
Firefox

Browser OS version:
88.0

Original install method (e.g. download page, yum, from source, etc.):
https://github.com/deviantony/docker-elk.git

Describe the bug:
On mouse hover over a fields value, the buttons filter in/out and so on move in from the right side. On fields with smaller columns space, it those buttons move under the mouse. If the users intention was to select a value to copy it and it will trigger an unintended action instead.

Steps to reproduce:

  1. Disable doc_table:legacy to use the "not legacy" table.
  2. Go to Discover.
  3. Make column space so small that a table cell is completely filled by the value.
  4. Hover over the cell with the intention to select the text.
  5. Left mouse click.

Expected behavior:
Text gets selected.

Screenshots (if relevant):
Animation

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:
This behavior is basically Clickjacking. To solve it, maybe put the buttons below the cell so that the user can not click on them accidentally.

@ypid-geberit ypid-geberit added the bug Fixes for quality problems that affect the customer experience label May 5, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label May 5, 2021
@wylieconlon wylieconlon added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed needs-team Issues missing a team label labels May 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes
Copy link
Contributor

timroes commented May 5, 2021

cc @chandlerprall Since this is something internal to how Data Grid works, I wanted to raise awareness for you, since I don't think there's anything we can do against that on the Kibana side?

@timroes timroes removed the bug Fixes for quality problems that affect the customer experience label Jul 14, 2021
@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@cee-chen
Copy link
Contributor

I think this is similar/related to elastic/eui#5828. Essentially, it sounds like data grid needs to check when the cell is too small for the cell actions to display without blocking the majority of the content, and figure out some other way of displaying the cell actions.

@JasonStoltz
Copy link
Member

@cee-chen Does elastic/eui#7343 close this?

@cee-chen
Copy link
Contributor

cee-chen commented Dec 7, 2023

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked EUI Feature:Discover Discover Application impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

9 participants