Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all expression public API's to expose partial results #98280

Closed
Tracked by #84051
ppisljar opened this issue Apr 26, 2021 · 1 comment · Fixed by #102403
Closed
Tracked by #84051

update all expression public API's to expose partial results #98280

ppisljar opened this issue Apr 26, 2021 · 1 comment · Fixed by #102403
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort

Comments

@ppisljar
Copy link
Member

ppisljar commented Apr 26, 2021

parent issue: #84051

expression public API's should expose underlying observable so consumers can start using partial results

  • run and execute functions on expression service (client and server) should return observable
  • expression loader (loader.ts) should have partialResults parameter
    • if using partial results we should call renderer on every step
    • (option a) the data$ observable could directly provide the output of every step (what we send to renderer) together with meta information if this is the final output or a partial one
    • (option b) the output data$ observable could provide the observable instead of final value
  • ReactExpressionRenderer should be updated to correctly consume the loader and pass forward the data of every step together with meta information if this is the final response (assuming option a above)
@ppisljar ppisljar added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppServices labels Apr 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort loe:large Large Level of Effort and removed loe:small Small Level of Effort labels Apr 26, 2021
@petrklapka petrklapka added 1 and removed 1 labels May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants