Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Prevent moving average from having a window size of 0 or negative #85893

Closed
wylieconlon opened this issue Dec 15, 2020 · 5 comments
Closed

[Lens] Prevent moving average from having a window size of 0 or negative #85893

wylieconlon opened this issue Dec 15, 2020 · 5 comments
Assignees
@wylieconlon
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@wylieconlon
Copy link
Contributor

As discovered in #84384, the number input for the moving average window size is not limiting the user input to positive numbers.
@wylieconlon wylieconlon added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Dec 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon wylieconlon mentioned this issue Dec 15, 2020
Merged
7 tasks
@wylieconlon wylieconlon self-assigned this Dec 16, 2020
@wylieconlon
Copy link
Contributor Author

I'm planning on doing this as part of the editor UI, it's a very simple fix

@flash1293
Copy link
Contributor

@wylieconlon do you still plan to do this on your PR or should I take it over?

@wylieconlon
Copy link
Contributor Author

@flash1293 I think it's already available in my PR- just added min={1}

@wylieconlon
Copy link
Contributor Author

Closed by #84384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wylieconlon wylieconlon

Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wylieconlon @flash1293 @elasticmachine