Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting UI] Console error on open Alert create flyout. #85211

Closed
YulNaumenko opened this issue Dec 7, 2020 · 1 comment · Fixed by #85462
Closed

[Alerting UI] Console error on open Alert create flyout. #85211

YulNaumenko opened this issue Dec 7, 2020 · 1 comment · Fixed by #85462
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@YulNaumenko
Copy link
Contributor

Kibana version:
master

Describe the bug:
Console error appears when user clicks on create Alert flyout in APM application.

Steps to reproduce:

  1. Open APM application
  2. Click Alerts -> Transaction error rate -> Create threshold alert
  3. Flyout is opened and observe a console error:

Errors in browser console (if relevant):

react_devtools_backend.js:2430 Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
    in AlertAdd (created by AlertingFlyout)
    in Suspense (created by AlertingFlyout)

Any additional context:
We might need here to refactor the approach about the closing Flyout like it was done for connectors. Instead of passing the props

setAddFlyoutVisibility: React.Dispatch<React.SetStateAction<boolean>>;
addFlyoutVisible: boolean;

it is better to expose onClose method to allow external plugins to manage the flyout behavior onClose event.

@YulNaumenko YulNaumenko added bug Fixes for quality problems that affect the customer experience Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Dec 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@ymao1 ymao1 self-assigned this Dec 9, 2020
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants