Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss tweaking version compatibility with elasticsearch #8267

Closed
ppf2 opened this issue Sep 14, 2016 · 5 comments
Closed

Discuss tweaking version compatibility with elasticsearch #8267

ppf2 opened this issue Sep 14, 2016 · 5 comments
Labels

Comments

@ppf2
Copy link
Member

ppf2 commented Sep 14, 2016

Continuing the discussion from here. Re-posting with @spalger feedback below:

The chart is showing that if the ES minor version is higher, it will throw a warning. Do we intend to support higher ES minor version (may have breaking changes in ES), or just higher ES patch version (typically no breaking changes in ES for patch versions)?

Yes, we will support but warn about users running a version of elasticsearch that has a higher minor or patch version than Kibana. This way, users can upgrade elasticsearch first and then Kibana once that is complete.

All the version combinations with "Compatible" and "Warning" are the ones we will be formally testing correct?

Good question :) @LeeDr?

But what does it mean from an operational/supportability point of view

I think the idea is that Elasticsearch will be stable enough through a major version to support Kibana, as long as a minimum minor version is met, but @epixa can probably add some color here.

@ppf2 ppf2 added the discuss label Sep 14, 2016
@ppf2
Copy link
Member Author

ppf2 commented Sep 14, 2016

One more comment:

If your Elasticsearch has an older version number or a newer major number than Kibana, then Kibana will fail to run (🚫). "

Does this mean that we do not expect to have the same situation (like today) moving forward - i.e. ES 2.4.0 is the latest version released for Elasticsearch and Kibana 4.6.1 is the latest Kibana version released (so ES 2.4.0 is 1 older version than Kibana's 4.6.1)? This is something to consider esp. for Cloud (like how Cloud has upgraded to Kibana 4.6.1 now with ES still staying on 2.4.0).

@epixa
Copy link
Contributor

epixa commented Sep 14, 2016

That situation will not happen in 5.0 onward. Any bump to any part of our stack will bump the whole stack.

On Sep 14, 2016, at 1:49 AM, Pius notifications@github.com wrote:

One more comment:

If your Elasticsearch has an older version number or a newer major number than Kibana, then Kibana will fail to run (🚫). "

Does this mean that we do not expect to have the same situation (like today) moving forward - i.e. ES 2.4.0 is the latest version released for Elasticsearch and Kibana 4.6.1 is the latest Kibana version released (so ES 2.4.0 is 1 older version than Kibana's 4.6.1)? This is something to consider esp. for Cloud (like how Cloud has upgraded to Kibana 4.6.1 now with ES still staying on 2.4.0).


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@LeeDr
Copy link

LeeDr commented Sep 14, 2016

Let's go through a scenario or two of a patch release and see if we agree how it plays out.

We have to patch Kibana because of a security issue. So let's say we build the whole stack at 5.0.1.
I think this means each product has to branch and update versions?
We test the whole stack at 5.0.1 (as much as this one fix needs testing).
We release the whole stack.
Maybe the Kibana release notes describe the fix?
The other products don't update release notes? Or do they say nothing changed?
A customer knows only Kibana changed and wants to upgrade only that product but can't because we don't allow Kibana to be 1 patch version ahead of Elasticsearch? :-(
I think this would be totally unacceptable. I'm sure the effort to upgrade large Elasticsearch clusters is not trivial in production.
Patch releases should NOT break compatibility with the same major.minor of the other products. If the change does break compatibility it must bump at least the minor version (so 5.1.0 in this case). Then it's clear that everything needs to be updated.

Same scenario but with an Elasticsearch patch. Do we force the customer to upgrade Kibana? And all the plugins? That also means we force ourselves to do a (minimal) round of testing when we haven't changed anything.

@epixa
Copy link
Contributor

epixa commented Sep 14, 2016

The upgrade policy in 5.0 onward is that you should upgrade the whole stack together even for patch versions.

That said, we could probably add a case to be a little less strict at the patch level. So even though technically our upgrade policy doesn't support this, Kibana wouldn't fail to run if ES was at a low patch level and it would instead render out a warning message to console that says that this setup is unsupported and that we encourage them to upgrade their ES nodes as soon as possible.

Edit: That would at least technically allow a user apply an urgent security fix or something to Kibana and then upgrade the rest of their stack next, though that wouldn't be a supported workflow.

@spalger spalger changed the title Continuing the discussion on PR 8229 Discuss tweaking version compatibility with elasticsearch Oct 3, 2016
@epixa
Copy link
Contributor

epixa commented Oct 3, 2016

I'm closing this discuss ticket in favor of the consensus change: #8515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants