Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] React key warning when opening popover with external resources #80296

Closed
cauemarcondes opened this issue Oct 13, 2020 · 2 comments · Fixed by #80328
Closed

[APM] React key warning when opening popover with external resources #80296

cauemarcondes opened this issue Oct 13, 2020 · 2 comments · Fixed by #80328
Assignees
@cauemarcondes
Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services. technical debt Improvement of the software architecture and operational architecture

Comments

@cauemarcondes
Copy link
Contributor

Open the Service Maps and click to open the popover that shows a list with all external resources. React throws a warning message saying we should add the key property.

react_devtools_backend.js:2273 Warning: Each child in a list should have a unique "key" prop.

Check the render method of `Info`. See https://fb.me/react-warning-keys for more information.
    in Fragment (created by Info)
    in Info (created by Contents)
    in div (created by EuiFlexItem)
    in EuiFlexItem (created by FlexColumnItem)
    in FlexColumnItem (created by Contents)
    in div (created by EuiFlexGroup)
    in EuiFlexGroup (created by FlexColumnGroup)

Add a key property here https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/public/components/app/ServiceMap/Popover/Info.tsx#L74:L74
@cauemarcondes cauemarcondes added [zube]: Inbox Team:APM - DEPRECATED Use Team:obs-ux-infra_services. technical debt Improvement of the software architecture and operational architecture labels Oct 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv
Copy link
Member

Let's try to get this fixed for 7.10

@cauemarcondes cauemarcondes self-assigned this Oct 13, 2020
@cauemarcondes cauemarcondes mentioned this issue Oct 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cauemarcondes cauemarcondes

Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] React key warning when opening popover with external resources cauemarcondes/kibana
4 participants
@graphaelli @sorenlouv @elasticmachine @cauemarcondes