Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Share alerting code better #80065

Closed
chrisronline opened this issue Oct 8, 2020 · 2 comments · Fixed by #83681
Closed

[Monitoring] Share alerting code better #80065

chrisronline opened this issue Oct 8, 2020 · 2 comments · Fixed by #83681
Assignees
Labels
chore Team:Monitoring Stack Monitoring team technical debt Improvement of the software architecture and operational architecture

Comments

@chrisronline
Copy link
Contributor

chrisronline commented Oct 8, 2020

Right now, each one of our alerts (cpu usage for example) contains a lot of similar code to the rest of the alerts. Now that we have a few of these under our belt, we need to figure out the right abstraction to use here.

AC:

  • Shared threshold alert functionality is moved into base alert
  • Server/UI shared elements moved into common folder

Notes:

  • We should log a separate ticket to figure out a better abstraction for the shared threshold UI code
@chrisronline chrisronline added the Team:Monitoring Stack Monitoring team label Oct 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@igoristic igoristic self-assigned this Oct 12, 2020
@igoristic igoristic added this to the Stack Monitoring UI 7.11 milestone Oct 12, 2020
@chrisronline
Copy link
Contributor Author

I'd like to also add we should normalize on adding these two properties to every alert state:

We should add them to the generic AlertState interface and make them optional because some alerts won't apply to a specific product instance/node.

Or maybe we can create two interfaces, one for alerts that apply to specific instances/nodes and one that does not.

Either way, we need to consolidate so we can leverage more generic flows in the client, such as generically showing the stack product name in places (right now, we can't easily because alerts store them differently)

@jasonrhodes jasonrhodes added chore technical debt Improvement of the software architecture and operational architecture labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Monitoring Stack Monitoring team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants