Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Case] Improve ServiceConnectorCaseParams type #79697

Closed
cnasikas opened this issue Oct 6, 2020 · 1 comment · Fixed by #80109
Closed

[Security Solution][Case] Improve ServiceConnectorCaseParams type #79697

cnasikas opened this issue Oct 6, 2020 · 1 comment · Fixed by #80109
Assignees
@cnasikas
Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@cnasikas
Copy link
Member

cnasikas commented Oct 6, 2020

On

kibana/x-pack/plugins/case/common/api/cases/case.ts

Lines 132 to 142 in c355dfe

export const ServiceConnectorCaseParamsRt = rt.type({
savedObjectId: rt.string,
createdAt: rt.string,
createdBy: ServiceConnectorUserParams,
externalId: rt.union([rt.string, rt.null]),
title: rt.string,
updatedAt: rt.union([rt.string, rt.null]),
updatedBy: rt.union([ServiceConnectorUserParams, rt.null]),
description: rt.union([rt.string, rt.null]),
comments: rt.union([rt.array(ServiceConnectorCommentParamsRt), rt.null]),
});
we do not define each connector's fields. We need to improve the type to accommodate this.
@cnasikas cnasikas added Team:SIEM Team:Threat Hunting Security Solution Threat Hunting Team labels Oct 6, 2020
@cnasikas cnasikas self-assigned this Oct 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

This was referenced Oct 6, 2020
Merged
Merged
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnasikas cnasikas

Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution][Case] Improve ServiceConnectorCaseParams type cnasikas/kibana
3 participants
@MindyRS @cnasikas @elasticmachine