Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GS] avoid unnecessary /internal/global_search/find http call at startup #78785

Closed
pgayvallet opened this issue Sep 29, 2020 · 3 comments · Fixed by #112535
Closed

[GS] avoid unnecessary /internal/global_search/find http call at startup #78785

pgayvallet opened this issue Sep 29, 2020 · 3 comments · Fixed by #112535
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Navigational Search Global search bar Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

The debounce call the SearchBar component is using does not check if the searchbar is currently active / focused

This is causing an unnecessary call to /internal/global_search/find when the kibana starts on the client-side, for every users.

@pgayvallet pgayvallet added the REASSIGN from Team:Core UI Deprecated label for old Core UI team label Sep 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@pgayvallet pgayvallet added the bug Fixes for quality problems that affect the customer experience label Sep 29, 2020
@myasonik
Copy link
Contributor

So one benefit of this route is that the results are already loaded by the time a user focuses on the search bar.

Is the extra call a problem?

@pgayvallet
Copy link
Contributor Author

Even if minor, performance-wise, that's an extra, potentially useless if the user never uses the feature, call that is performed during a timeframe already crawled with http calls (start lifecycle), so it would be an improvement to remove it.

Note that this issue would be resolved by addressing #78771, if we decide to fetch the apps for the default/initial result listing from the application service instead of calling GS.

@ryankeairns ryankeairns added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed REASSIGN from Team:Core UI Deprecated label for old Core UI team labels Jan 19, 2021
@pgayvallet pgayvallet added the Feature:Navigational Search Global search bar label Apr 6, 2021
@shahzad31 shahzad31 self-assigned this Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Navigational Search Global search bar Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
5 participants