Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up & formalise usage of: Action, InnerAction, ActionDefinition, createAction() #74501

Closed
Dosant opened this issue Aug 6, 2020 · 2 comments
Closed

Clean up & formalise usage of: Action, InnerAction, ActionDefinition, createAction() #74501

Dosant opened this issue Aug 6, 2020 · 2 comments
Labels
Feature:UIActions UI actions. These are client side only, not related to the server side actions.. impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture

Comments

@Dosant
Copy link
Contributor

Dosant commented Aug 6, 2020 •
edited
Loading

uiActions provide multiple ways to define and register an action:

  • Action interface
  • ActionDefinition interface
  • ActionByType interface
  • createAction function

having so many methods is confusing.
we should at least document when to use what and probably reduce number of possible methods
@Dosant Dosant added technical debt Improvement of the software architecture and operational architecture Team:AppArch Feature:UIActions UI actions. These are client side only, not related to the server side actions.. labels Aug 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant mentioned this issue Aug 10, 2020
Merged
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@ppisljar
Copy link
Member

ppisljar commented Aug 8, 2022

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:UIActions UI actions. These are client side only, not related to the server side actions.. impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Dosant @ppisljar @elasticmachine