Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions link for UI actions and connectors should go to enterprise page for ECK #70376

Closed
Tracked by #71854
peterschretlen opened this issue Jun 30, 2020 · 8 comments
Labels
blocked bug Fixes for quality problems that affect the customer experience estimate:small Small Estimated Level of Effort Feature:Actions/ConnectorsManagement Issues related to Connectors Management UX Feature:Actions Feature:Drilldowns Embeddable panel Drilldowns impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@peterschretlen
Copy link
Contributor

peterschretlen commented Jun 30, 2020

Both links go to https://www.elastic.co/subscriptions
But when running in ECK they should direct the user to https://www.elastic.co/subscriptions/enterprise page

I don't consider it a priority issue but logging it for tracking. Since we have now two places with this URL hardcoded and it changes by product, we may want to find a central place for it at a minimum, and find a way to configure it.

Connectors UI:
image

UI Actions:
image

@peterschretlen peterschretlen added bug Fixes for quality problems that affect the customer experience Team:AppArch Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Drilldowns Embeddable panel Drilldowns labels Jun 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@peterschretlen peterschretlen changed the title Upgrade link for UI actions and connectors should go to enterprise page for ECK Subscriptions link for UI actions and connectors should go to enterprise page for ECK Jun 30, 2020
@pmuellr
Copy link
Member

pmuellr commented Jul 2, 2020

Thinking it probably makes sense to make that link configurable, with a default of https://www.elastic.co/subscriptions - and then we would arrange to override it in the ECK config (I assume there would be a way to do that).

If alerting is the only affected component, it could be an alerting specific config, but ... that doesn't feel right - I'd imagine other apps / solutions will eventually want these links as well.

@streamich streamich mentioned this issue Jul 16, 2020
26 tasks
@Dosant
Copy link
Contributor

Dosant commented Sep 10, 2020

@elastic/kibana-platform, do you think this dynamic link should become a part of licensing plugin? Or maybe part of docLinks to be available in OSS?

@pgayvallet
Copy link
Contributor

If the link target only got two possible values, and only depends on whether kibana runs on ECK or not, it could be possible to add the link in the docLink service and handle the switch internally/automatically.

@joshdover WDYT? Do we want to be aware of our running environment from within core? If we do, we need to have a way to know if we are running on ECK in core, as the information is currently only available from the cloud plugin

@Dosant
Copy link
Contributor

Dosant commented Oct 1, 2020

FYI: one more occurrence: #79045

@ppisljar ppisljar added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Apr 29, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jun 21, 2021
@gmmorris gmmorris added the Feature:Actions/ConnectorsManagement Issues related to Connectors Management UX label Jul 1, 2021
@gmmorris
Copy link
Contributor

gmmorris commented Jul 15, 2021

pinging @lukeelmers :)

Looking at this backlog item looks like it's on hold for us to decide if this can be managed via the docLink.
If this is the case, I'd ideally like to mark this as blocked for our team until that need is addressed at core level.
If this isn't the case, then we can look at how we might solve this at another level 🤔

@gmmorris gmmorris added the estimate:small Small Estimated Level of Effort label Aug 18, 2021
@gmmorris gmmorris removed the loe:medium Medium Level of Effort label Sep 2, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
@ppisljar
Copy link
Member

ppisljar commented Aug 8, 2022

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Fixes for quality problems that affect the customer experience estimate:small Small Estimated Level of Effort Feature:Actions/ConnectorsManagement Issues related to Connectors Management UX Feature:Actions Feature:Drilldowns Embeddable panel Drilldowns impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

No branches or pull requests

9 participants