Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Jump to trace filter is invalid and return more than expected #69500

Closed
Sayrus opened this issue Jun 18, 2020 · 1 comment · Fixed by #69504
Closed

[APM] Jump to trace filter is invalid and return more than expected #69500

Sayrus opened this issue Jun 18, 2020 · 1 comment · Fixed by #69504
Assignees
Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services.

Comments

@Sayrus
Copy link
Contributor

Sayrus commented Jun 18, 2020

Kibana version: 7.7.1

Elasticsearch version: 7.7.1

Server OS version: N/A

Browser version: N/A

Browser OS version: N/A

Original install method (e.g. download page, yum, from source, etc.): N/A

Describe the bug:

The current filter returns more content than expected:

filter: `trace.id:"${transaction.trace.id}" OR ${transaction.trace.id}`

The second part not being quoted means that depending on your configuration this can actually match any individual character in your logs.

Steps to reproduce:

  1. Open a trace in the APM section
  2. Use Jump to trace action
  3. Filter is trade.id: "XXXXXXXXXXID" OR XXXXXXXXXXID
  4. Logs returned from this filter are nearly everything in the cluster

Expected behavior:
Only logs from the filtered trace are returned

Screenshots (if relevant):

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

Sayrus added a commit to Sayrus/kibana that referenced this issue Jun 18, 2020
Signed-off-by: Mathis Raguin <mathis@cri.epita.fr>
@monfera monfera added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Jun 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@zube zube bot assigned sorenlouv Jun 29, 2020
sorenlouv pushed a commit that referenced this issue Jul 7, 2020
* [APM] Quote trace id to ensure a word is searched (#69500)

Signed-off-by: Mathis Raguin <mathis@cri.epita.fr>

* [APM] Fix TransactionActionMenu tests (one test was not updated)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sorenlouv pushed a commit to sorenlouv/kibana that referenced this issue Jul 7, 2020
…astic#69504)

* [APM] Quote trace id to ensure a word is searched (elastic#69500)

Signed-off-by: Mathis Raguin <mathis@cri.epita.fr>

* [APM] Fix TransactionActionMenu tests (one test was not updated)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sorenlouv added a commit that referenced this issue Jul 7, 2020
…70977)

* [APM] Quote trace id to ensure a word is searched (#69500)

Signed-off-by: Mathis Raguin <mathis@cri.epita.fr>

* [APM] Fix TransactionActionMenu tests (one test was not updated)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Mathis <Sayrus@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants