Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Convert client routing files to TS #69448

Closed
kindsun opened this issue Jun 17, 2020 · 4 comments · Fixed by #76387
Closed

[Maps] Convert client routing files to TS #69448

kindsun opened this issue Jun 17, 2020 · 4 comments · Fixed by #76387
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation

Comments

@kindsun
Copy link
Contributor

kindsun commented Jun 17, 2020

#65079 introduces several files which ultimately need to be converted to TypeScript. This effectively includes every .js file under the Maps > public > routing directory.
@kindsun kindsun added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Jun 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kindsun kindsun mentioned this issue Jun 17, 2020
Merged
@shamin
Copy link
Contributor

shamin commented Aug 17, 2020

@aaronjcaldwell I would like to try this. Can I work on it?

@kindsun
Copy link
Contributor Author

kindsun commented Aug 17, 2020

Certainly @shamin. Thanks for the help! 👍

@shamin shamin mentioned this issue Sep 1, 2020
Merged
7 tasks
@shamin
Copy link
Contributor

shamin commented Sep 1, 2020

Hi @aaronjcaldwell, I have created a PR with the typescript conversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert map client routing files to TS shamin/kibana
3 participants
@kindsun @shamin @elasticmachine