Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create button in empty state for dashboard #62070

Closed
gchaps opened this issue Mar 31, 2020 · 5 comments · Fixed by #63403
Closed

Create button in empty state for dashboard #62070

gchaps opened this issue Mar 31, 2020 · 5 comments · Fixed by #63403
Labels
Feature:Dashboard Dashboard related features Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@gchaps
Copy link
Contributor

gchaps commented Mar 31, 2020

This screenshots shows three buttons with the wording "Create new". The EUI button guidelines say to avoid the wording "Create new" and instead follow "Create" with a noun, such as "Create visualization" or "Create dashboard".

Screen Shot 2020-03-31 at 12 36 21 PM

@gchaps gchaps added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Design)

@cchaos cchaos added the Feature:Dashboard Dashboard related features label Mar 31, 2020
@ryankeairns
Copy link
Contributor

While I agree this screenshot looks odd, and the buttons could be more consistent (e.g. use the same icon and icon placement), there are a few things to keep in mind as this project is still mid flight:

  • There are more changes coming, but the general thrust is that we want people to create new content from Dashboard and avoid the traditional 'Add' (flyout) approach to adding existing objects. That said, it still needs to be accessible, but we're expecting users to not use this flyout as frequently going forward.
  • In the case of dashboards, you'll be able to create a variety of objects - not just visualizations - which means the button label needs to be generic (and not super long). For example, you can create and display Maps and Saved searches too, so while it is a little out of the norm, it seems warranted for this specific use case.
  • We were on the the path to keeping the empty panel always visible in the grid and had shelved the menu button idea... but then the menu button came into the mix, somewhat unexpectedly, so we ended up with both solutions. The panel had already been implemented for the empty state, and still hints at adding a panel, but perhaps it could be a link or hollow button to reduce visual redundancy.
  • The benefit of the button in the nav is that its more accessible once the dashboard fills in and we've discussed fixing the top section when scrolling.

I share all that for context, but it doesn't mean there isn't room for improvement. Looking at this again with a fresh set of eyes, I would propose unifying the button designs in the menu and flyout and use a non-filled button in the empty panel.

@cchaos
Copy link
Contributor

cchaos commented Mar 31, 2020

Quick question about the "Create new" button in the top menu. Is that to create a new object for a panel or a whole new dashboard? Looking at the rest of the menu I see "Add" but I no longer see the old "New" menu item that originally created the new dashboard.

@ryankeairns
Copy link
Contributor

Quick question about the "Create new" button in the top menu. Is that to create a new object for a panel or a whole new dashboard? Looking at the rest of the menu I see "Add" but I no longer see the old "New" menu item that originally created the new dashboard.

Create a new object/panel (opens the Visualize type picker).

Objects created from Dashboard would live with the dashboard, as opposed to being added to the Visualize 'library'. That part is not quite complete but there is/will be an emphasis on the 'Create new' route vs 'Add' (which is being intentionally downplayed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants