Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Show warning prompt when navigating away #61854

Closed
timroes opened this issue Mar 30, 2020 · 3 comments · Fixed by #67689
Closed

[Lens] Show warning prompt when navigating away #61854

timroes opened this issue Mar 30, 2020 · 3 comments · Fixed by #67689
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Mar 30, 2020

Lens should show a warning prompt when navigating away while there are still unsafed changes, since a user would lose all those when navigating away. Once moved to the new platform and using the new application mount service, we can easily implement that using the onAppLeave API for that.

@timroes timroes added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Mar 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

Looks like this is now possible because we are on the new platform. I think this is worth prioritizing as a fix-it-week issue because it sounds like a small fix with high impact.

@mbondyra
Copy link
Contributor

mbondyra commented May 28, 2020

As a user, when navigating away from the unsaved lens visualisation, I should see the popup warning about unsaved changes.

  1. Show the popup if user wants to refresh the page.
  2. Show the popup if user uses Kibana navigation to go somewhere else (with back button or sidebar menu)
  3. Don't show the popup if the visualisation was just saved and no new changes were added in the meantime.
  4. The flow should also work from new dashboard flow standpoint.

@mbondyra mbondyra linked a pull request May 29, 2020 that will close this issue
2 tasks
@wylieconlon wylieconlon linked a pull request May 29, 2020 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants