Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPM] Implement correct handling of array field type in mappings #60498

Closed
skh opened this issue Mar 18, 2020 · 2 comments
Closed

[EPM] Implement correct handling of array field type in mappings #60498

skh opened this issue Mar 18, 2020 · 2 comments
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@skh
Copy link
Contributor

skh commented Mar 18, 2020

The current handling of fields of type array in the generation of index template mappings is incomplete.

This task is to look at the current behavior of index template generation with regard to array fields in libbeats and implement it for mapping generation in ingest_manager/server/services/epm/elasticsearch/template/.

In particular, when no object_type is present the field shouldn't be added at all (see https://github.com/elastic/beats/blob/master/libbeat/template/processor.go#L123-L124 and https://github.com/elastic/beats/blob/master/libbeat/template/processor_test.go#L101-L107).

Also, add unit tests for the new behavior.

@skh skh added the Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project label Mar 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

@skh
Copy link
Contributor Author

skh commented Mar 18, 2020

Fixed in #60266 after all.

@skh skh closed this as completed Mar 18, 2020
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

3 participants