Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Lens does save the pinned filters into the visualization #56627

Closed
timroes opened this issue Feb 3, 2020 · 2 comments · Fixed by #57197
Closed

[Lens] Lens does save the pinned filters into the visualization #56627

timroes opened this issue Feb 3, 2020 · 2 comments · Fixed by #57197
Assignees
@mbondyra
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Feb 3, 2020

Lens currently saves also pinned filters with the visualization. Our current behavior across other apps is, not to save pinned filters into any saved object. So we should do the same in Lens. This still leaves aside, that the UX around that is currently not good, because it's not obvious to the user that some filters are saved and others not, and we had another issue to discuss that, which I unfortunately can't find at the moment. I'll link it here as soon as I am able to find it again.
@timroes timroes added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Feb 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes mentioned this issue Feb 3, 2020
Merged
@Dosant
Copy link
Contributor

Dosant commented Feb 4, 2020

Our current behaviour across other apps is, not to save pinned filters into any saved object.

@timroes, Is it also true for dashboard? I think in 7.6 dashboard also saves pinned filters to saved object. Also a regression?

@mbondyra mbondyra self-assigned this Feb 10, 2020
@mbondyra mbondyra mentioned this issue Feb 10, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbondyra mbondyra

Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] Filter out pinned filters from saved object of Lens mbondyra/kibana
4 participants
@timroes @mbondyra @Dosant @elasticmachine