-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Improve client-side routes #51963
Labels
apm:test-plan-done
Pull request that was successfully tested during the test plan
Team:APM - DEPRECATED
Use Team:obs-ux-infra_services.
technical debt
Improvement of the software architecture and operational architecture
Comments
Pinging @elastic/apm-ui (Team:apm) |
I have intentionally left out breadcrumb support in the issue above. It's currently making everything even more complicated so we might drop our implementation and try something a lot simpler (more dumb). |
12 tasks
2 tasks
Super cool @dgieselaar. Do we need to wait for react-router v6 to land before starting this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
apm:test-plan-done
Pull request that was successfully tested during the test plan
Team:APM - DEPRECATED
Use Team:obs-ux-infra_services.
technical debt
Improvement of the software architecture and operational architecture
The client side routes should resemble the server side routes:
useUrlParams
andresolveUrlParams
)useLocation
oruseUrlParams
components should receive their route params as props.Currently client side routes look like:
In the future it should look something like
Then from the component:
Retrieve route params from deeply nested component
We could also make a helper to make it easier to obtain route params deep down in the tree (although we can't ensure it's called from the right component, so its use should be limited):
Linking to a route
Get the full href string:
push new item to history API:
Replace existing item on history API
As a component:
The text was updated successfully, but these errors were encountered: