Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upgrade Assistant] Remove Axios #51011

Closed
jloleysens opened this issue Nov 19, 2019 · 3 comments · Fixed by #58034
Closed

[Upgrade Assistant] Remove Axios #51011

jloleysens opened this issue Nov 19, 2019 · 3 comments · Fixed by #58034
Labels
chore Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@jloleysens
Copy link
Contributor

jloleysens commented Nov 19, 2019 •
edited
Loading

Summary

After this PR is merged: #50163

It would be good to remove axios from Upgrade Assistant entirely as it duplicates work that is being taken care of in the http service like:

  • adding custom headers
  • built-in redirection behaviour

Additional

Original comment: #50163 (comment)
@jloleysens jloleysens added chore Feature:Upgrade Assistant v7.6.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Nov 19, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@LeeDr
Copy link

LeeDr commented Jan 16, 2020

We're past 7.6.0 Feature Freeze so if this isn't a bug it should probably bump to v7.7.0.

@cjcenizal cjcenizal removed the v7.6.0 label Jan 16, 2020
@cjcenizal
Copy link
Contributor

Thanks @LeeDr. I removed the version label. Generally speaking, I think we try to reserve them for PRs.

@jloleysens jloleysens mentioned this issue Feb 19, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Upgrade Assistant] Move out of legacy folder jloleysens/kibana
4 participants
@cjcenizal @jloleysens @LeeDr @elasticmachine