Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image field formatter width/height params prematurely documented #50328

Closed
bcamper opened this issue Nov 12, 2019 · 7 comments
Closed

Image field formatter width/height params prematurely documented #50328

bcamper opened this issue Nov 12, 2019 · 7 comments
Labels
bug Fixes for quality problems that affect the customer experience Team:Docs

Comments

@bcamper
Copy link

bcamper commented Nov 12, 2019

It looks like the new image field formatter width/height params (#46917) were prematurely documented in the 7.4 docs:

https://www.elastic.co/guide/en/kibana/7.4/field-formatters-string.html

For an Image type you can specify width and height attributes. These will be used to set the max width / max height of the image, while keeping the aspect ratio. Image will not be upscaled if it’s smaller than the provided size parameters.

It looks like that was added for 7.4 (which it should be removed from), but not for 7.5 (whether it belongs there depends on whether it ends up backported for 7.5 release or not #50323) or for master.

@bcamper
Copy link
Author

bcamper commented Nov 12, 2019

cc @majagrubic @nreese

@nreese nreese added bug Fixes for quality problems that affect the customer experience Team:Docs labels Nov 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@nreese
Copy link
Contributor

nreese commented Nov 12, 2019

Looking into this issue, there are 2 problems.

The original PR making the functionality changes, #46917, was merged into master but never backported.

The doc changes were merged directly into 7.4 branch and no other branches, with 38f666c#diff-e0be25b5011f4c8b34470aa764aade36.

@majagrubic Can you

  1. backport Adding width and height as parameters to image url #46917 to 7.x.
  2. backport Adding width and height as parameters to image url #46917 to 7.5.
  3. revert the doc changes from 7.4.
  4. Follow the normal flow and reintroduce the documenation changes. Create a PR in master and get docs team to review. Then backport the PR to 7.x and 7.5 branches.

Thanks

@KOTungseth
Copy link
Contributor

@majagrubic if you run into any issues, feel free to reach out to me or @gchaps.

@majagrubic
Copy link
Contributor

majagrubic commented Dec 7, 2019

Sorry, this completely slipped my radar.
This was already backported to

  1. 7.x [7.x] Adding width and height as parameters to image url (#46917) #50406
  2. 7.5 [7.5] Adding width and height as parameters to image url (#46917) #52457
  3. Reverted changes to 7.4 docs: 3e2ce3d

I'll reintroduce the doc changes now.

@majagrubic
Copy link
Contributor

Re-introduced the doc changes and backported. I hope this issue can be closed now?

Once again, sorry for the confusion introduced here.

@nreese
Copy link
Contributor

nreese commented Dec 9, 2019

Yes, this issue can be closed. thanks for cleaning everything up.

@nreese nreese closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Docs
Projects
None yet
Development

No branches or pull requests

5 participants