Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Triple quote expansion on strings that should not be triple quoted #46113

Closed
jloleysens opened this issue Sep 19, 2019 · 3 comments
Closed
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@jloleysens
Copy link
Contributor

Kibana version:
7.3 (reproduced on pending 7.5)

Describe the bug:
Escaped quotes that should not be triple-quoted are.

Steps to reproduce:
In Console's editor when I use a string starting and ending with an escaped double quote:

PUT bar/_doc/1
{
  "content": "\"triple\""
}

auto-indents gives me here:

PUT bar/_doc/1
{
  "content": """"triple""""
}

Which generates an error, as we now have something starting and ending with four quotes, which is interpreted as a string "triple, followed by an unexpected extra double quote.

Expected behavior:
"\"triple\"" should not be triple quote expanded.

Additional Context
Originally reported here: #44729 (comment)

@jloleysens jloleysens added bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Sep 19, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@jloleysens
Copy link
Contributor Author

jloleysens commented Sep 22, 2019

#36570 These can can be addressed together (if we can get console to treat """"mystring"""" correctly).

@jloleysens
Copy link
Contributor Author

Closed by #54474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

2 participants