Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Unable to create filters in dashboard #45104

Closed
nreese opened this issue Sep 7, 2019 · 2 comments · Fixed by #45187
Closed

[Maps] Unable to create filters in dashboard #45104

nreese opened this issue Sep 7, 2019 · 2 comments · Fixed by #45187
Assignees
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation regression

Comments

@nreese
Copy link
Contributor

nreese commented Sep 7, 2019

#44503 changed the embeddable API and did not update Maps usage of the API.

Need to change

https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/maps/public/embeddable/map_embeddable.js#L136

to

  addFilters = filters => {
    start.executeTriggerActions(APPLY_FILTER_TRIGGER, {
      embeddable: this,
      filters,
    });
  }
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@nreese nreese added bug Fixes for quality problems that affect the customer experience regression [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Sep 7, 2019
@nreese
Copy link
Contributor Author

nreese commented Sep 7, 2019

There are functional tests that would have prevented this regression, but they were disabled by #41272

cc @streamich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants