Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example plugins folder #26781

Closed
stacey-gammon opened this issue Dec 6, 2018 · 4 comments · Fixed by #52027
Closed

Example plugins folder #26781

stacey-gammon opened this issue Dec 6, 2018 · 4 comments · Fixed by #52027
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team

Comments

@stacey-gammon
Copy link
Contributor

Would be great to move the functional test plugins to a top level examples folder that can then be tests in whatever means.

Should have good docs for how to build, @spalger has some ideas on what needs to be done to support this.

@stacey-gammon stacey-gammon added the Team:Operations Team label for Operations Team label Dec 6, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@stacey-gammon stacey-gammon added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Dec 6, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@stacey-gammon
Copy link
Contributor Author

stacey-gammon commented Dec 2, 2019

I started to explore doing this here: https://github.com/elastic/kibana/pull/52027/files

I thought it'd be as easy as seeing what custom functionality there was for the plugins inside test/plugin_functional/plugins and adding that to this new top level examples folder, but it appears to not be that simple. Even though I added projectPaths.push(resolve(rootPath, 'examples/*')); inside packages/kbn-pm/src/config.ts, when I run yarn kbn bootstrap, the plugin folders do not get picked up.

I did omit a nested plugins folder, because it seemed not necessary, I wouldn't really expect that to cause an issue, but, maybe.

Anyone have any ideas?

*** Update**

@joshdover solved the issue - need to re-compile kbn-pm via cd packages/kbn-pm && yarn run build and commit the newly built file.

@stacey-gammon
Copy link
Contributor Author

cc @clintandrewhall - this is somewhat related to our discussion today. No matter where we end up building this documentation, it would be nice to have example plugins in here. We may need an x-pack examples folder too, though the interpreter fns are OSS so for now this may suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants