Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved Objects Management delete tooltip persisting #204095

Closed
TinaHeiligers opened this issue Dec 12, 2024 · 1 comment · Fixed by #204154
Closed

Saved Objects Management delete tooltip persisting #204095

TinaHeiligers opened this issue Dec 12, 2024 · 1 comment · Fixed by #204154
Assignees
@TinaHeiligers
Labels
bug Fixes for quality problems that affect the customer experience Feature:Saved Objects Management Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented Dec 12, 2024 •
edited
Loading

There's a bug in Saved Objects Management plugin where the tooltip on the delete button persists.

The bug only happens in Chrome. Firefox and Safari clear the tooltip as expected:

Chrome Version 131.0.6778.140 (Official Build) (arm64)
Image

Safari
Image
@TinaHeiligers TinaHeiligers added bug Fixes for quality problems that affect the customer experience Feature:Saved Objects Management Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Dec 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers TinaHeiligers self-assigned this Dec 12, 2024
@TinaHeiligers TinaHeiligers changed the title Saved Objects Management delete popover persisting Saved Objects Management delete tooltip persisting Dec 12, 2024
@TinaHeiligers TinaHeiligers mentioned this issue Dec 13, 2024
Merged
1 task
TinaHeiligers added a commit that referenced this issue Dec 13, 2024
@TinaHeiligers
Fix delete disabled state (#204154)
4ee5222 
fix #204095

Disables delete when no saved objects are selected or all objects
selected are hidden and delete is allowed.

![Screenshot 2024-12-12 at 18 02
10](https://github.com/user-attachments/assets/e894a087-7906-4905-bd2e-2325a90d37c0)


## Summary

Summarize your PR. If it involves visual changes include a screenshot or
gif.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 13, 2024
@TinaHeiligers
Fix delete disabled state (elastic#204154)
f210cb2 
fix elastic#204095

Disables delete when no saved objects are selected or all objects
selected are hidden and delete is allowed.

![Screenshot 2024-12-12 at 18 02
10](https://github.com/user-attachments/assets/e894a087-7906-4905-bd2e-2325a90d37c0)

## Summary

Summarize your PR. If it involves visual changes include a screenshot or
gif.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 4ee5222)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
@TinaHeiligers @CAWilson94
Fix delete disabled state (elastic#204154)
e8a5bc5 
fix elastic#204095

Disables delete when no saved objects are selected or all objects
selected are hidden and delete is allowed.

![Screenshot 2024-12-12 at 18 02
10](https://github.com/user-attachments/assets/e894a087-7906-4905-bd2e-2325a90d37c0)


## Summary

Summarize your PR. If it involves visual changes include a screenshot or
gif.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TinaHeiligers TinaHeiligers

Labels
bug Fixes for quality problems that affect the customer experience Feature:Saved Objects Management Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix delete disabled state TinaHeiligers/kibana
2 participants
@TinaHeiligers @elasticmachine