Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] use embeddable in editor #166522

Closed
drewdaemon opened this issue Sep 14, 2023 · 4 comments
Closed

[Lens] use embeddable in editor #166522

drewdaemon opened this issue Sep 14, 2023 · 4 comments
Labels
blocked Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@drewdaemon
Copy link
Contributor

drewdaemon commented Sep 14, 2023

Describe the feature:
We currently maintain two components for rendering Lens visualizations

  • Embeddable — used in dashboard and solutions
  • Workspace panel — used in the editor

At the end of the day, these two components both accept a Lens configuration, render it, emit user events, and respond to context changes (e.g. time range, visualization configuration, filters).

However, they are quite different implementations and this causes a maintenance burden over time.

For example, it took a lot of extra effort to get the User Messages system to work in both components.

The differences can lead to bugs, sometimes bad ones like #149667 which was only apparent in the Embeddable.

The way things are now also increases our testing surface since we can't depend on Lens to function the same outside the editor as it does inside.

We derived a lot of benefit from unifying the XY visualization expression renderers. I'm confident that we'd reap the same quality and stability benefits from unifying this part of the render stack as well.

@drewdaemon drewdaemon added loe:needs-research This issue requires some research before it can be worked on or estimated technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Sep 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula
Copy link
Contributor

Blocked by embeddables redesign. Let's assess then.

@stratoula stratoula added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Sep 18, 2023
@markov00
Copy link
Member

@dej611 is the new lens embeddable the answer to this?

@dej611
Copy link
Contributor

dej611 commented Nov 19, 2024

No.
But this can be closed as the main editor will be replaced with 100% inline editing in the future.

@dej611 dej611 closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

5 participants