Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] TLS cert alert toggle shouldn’t be there for ICMP monitors #161100

Closed
paulb-elastic opened this issue Jul 3, 2023 · 2 comments · Fixed by #161173
Closed

[Synthetics] TLS cert alert toggle shouldn’t be there for ICMP monitors #161100

paulb-elastic opened this issue Jul 3, 2023 · 2 comments · Fixed by #161173
Assignees
@shahzad31
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.0

Comments

@paulb-elastic
Copy link
Contributor

Adding enable/disable controls for the new TLS Certificate alert for Synthetic monitors was recently added in 8.9, however this has also been added to ICMP monitors, which do not do SSL/TLS certificate checks, so should be removed.

image

Steps to reproduce

  • Create a new monitor in the Synthetics UI
  • Select ICMP
  • Scroll down and see that there is an option to Enable TLS alerts (which there shouldn't be for ICMP)
@paulb-elastic paulb-elastic added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.0 labels Jul 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 self-assigned this Jul 4, 2023
@paulb-elastic
Copy link
Contributor Author

@shahzad31 is there a PR for this (see it's in review, but couldn't see one linked).

Also (nit), if you have a PR, can you update Enable tls alerts on this monitor. to uppercase TLS?
image

@shahzad31 shahzad31 mentioned this issue Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzad31 shahzad31

Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Synthetics] Remove TLS alert option for ICMP monitor shahzad31/kibana
3 participants
@shahzad31 @elasticmachine @paulb-elastic